Patch "ANDROID: binder: Clear binder and cookie when setting handle in flat binder struct" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ANDROID: binder: Clear binder and cookie when setting handle in flat binder struct
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
android-binder-clear-binder-and-cookie-when-setting-handle-in-flat-binder-struct.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
4afb604e2d14d429ac9e1fd84b952602853b2df5Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= <[email protected]>
Date: Mon, 24 Oct 2016 15:20:30 +0200
Subject: ANDROID: binder: Clear binder and cookie when setting handle in flat binder struct
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Arve Hjønnevåg <[email protected]>
commit 4afb604e2d14d429ac9e1fd84b952602853b2df5 upstream.
Prevents leaking pointers between processes
--- drivers/android/binder.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/android/binder.c +5 -0
@@ -1578,7 +1578,9 @@ static void binder_transaction(struct bi fp->type =BINDER_TYPE_HANDLE ; else fp->type = BINDER_TYPE_WEAK_HANDLE; + fp->binder =0 ; fp->handle = ref->desc; + fp->cookie =0 ;binder_inc_ref (ref, fp->type ==BINDER_TYPE_HANDLE , &thread->todo);
@@ -1628,7 +1630,9 @@ static void binder_transaction(struct bi return_error =BR_FAILED_REPLY ; goto err_binder_get_ref_for_node_failed; } + fp->binder =0 ; fp->handle = new_ref->desc; + fp->cookie =0 ;binder_inc_ref (new_ref, fp->type ==BINDER_TYPE_HANDLE ,NULL );trace_binder_transaction_ref_to_ref (t, ref, new_ref);
@@ -1682,6 +1686,7 @@ static void binder_transaction(struct bibinder_debug (BINDER_DEBUG_TRANSACTION ," fd %d -> %d\n" , fp->handle, target_fd);/* TODO: fput? */ + fp->binder =0 ; fp->handle = target_fd; }break ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/android-binder-add-strong-ref-checks.patch queue-4.4/android-binder-clear-binder-and-cookie-when-setting-handle-in-flat-binder-struct.patch