Skip to contentSkip to conversation

Patch "ubifs: Fix regression in ubifs_readdir()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Nov 7, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ubifs: Fix regression in ubifs_readdir()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ubifs-fix-regression-in-ubifs_readdir.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a00052a296e54205cf238c75bd98d17d5d02a6db Mon Sep 17 00:00:00 2001

From: Richard Weinberger <[email protected]>
Date: Fri, 28 Oct 2016 11:49:03 +0200
Subject: ubifs: Fix regression in ubifs_readdir()

From: Richard Weinberger <[email protected]>

commit a00052a296e54205cf238c75bd98d17d5d02a6db upstream.

Commit c83ed4c9dbb35 ("ubifs: Abort readdir upon error") broke overlayfs support because the fix exposed an internal error code to VFS.

---
 fs/ubifs/dir.c |    8 ++++++++
 1 file changed, 8 insertions(+)
fs/ubifs/dir.c +8 -0
@@ -454,6 +454,14 @@ out:
 
 	if (err != -ENOENT)
 		ubifs_err(c, "cannot find next direntry, error %d", err);
+	else
+		/*
+		 * -ENOENT is a non-fatal error in this context, the TNC uses
+		 * it to indicate that the cursor moved past the current directory
+		 * and readdir() has to stop.
+		 */
+		err = 0;
+
 
 	/* 2 is a special value indicating that there are no more direntries */
 	ctx->pos = 2;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ubifs-abort-readdir-upon-error.patch queue-4.4/ubifs-fix-regression-in-ubifs_readdir.patch