Skip to contentSkip to conversation

Patch "ovl: fix get_acl() on tmpfs" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 8, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ovl: fix get_acl() on tmpfs

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ovl-fix-get_acl-on-tmpfs.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b93d4a0eb308d4400b84c8b24c1b80e09a9497d0 Mon Sep 17 00:00:00 2001

From: Miklos Szeredi <[email protected]>
Date: Mon, 31 Oct 2016 14:42:14 +0100
Subject: ovl: fix get_acl() on tmpfs

From: Miklos Szeredi <[email protected]>

commit b93d4a0eb308d4400b84c8b24c1b80e09a9497d0 upstream.

tmpfs doesn't have ->get_acl() because it only uses cached acls.

This fixes the acl tests in pjdfstest when tmpfs is used as the upper layer of the overlay.

Fixes 39a25b2b3762 ("ovl: define ->get_acl() for overlay inodes")
---
 fs/overlayfs/inode.c |    3 ---
 1 file changed, 3 deletions(-)
fs/overlayfs/inode.c +0 -3
@@ -294,9 +294,6 @@ struct posix_acl *ovl_get_acl(struct ino
 	if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !IS_POSIXACL(realinode))
 		return NULL;
 
-	if (!realinode->i_op->get_acl)
-		return NULL;
-
 	old_cred = ovl_override_creds(inode->i_sb);
 	acl = get_acl(realinode, type);
 	revert_creds(old_cred);

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/ovl-update-s_isgid-when-setting-posix-acls.patch queue-4.8/ovl-fix-get_acl-on-tmpfs.patch queue-4.8/ovl-fsync-after-copy-up.patch