Skip to contentSkip to conversation

Patch "ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Nov 10, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ip6_gre-fix-flowi6_proto-value-in-ip6gre_xmit_other.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Nov 10 16:42:45 CET 2016

From: Lance Richardson <[email protected]>
Date: Fri, 23 Sep 2016 15:50:29 -0400
Subject: ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

From: Lance Richardson <[email protected]>

[ Upstream commit db32e4e49ce2b0e5fcc17803d011a401c0a637f6 ]

Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup.

Up until now, ip6gre_xmit_other() has set flowi6_proto to a bogus value. This affected output route lookup for packets sent on an ip6gretap device in cases where routing was dependent on the value of flowi6_proto.

Since the correct proto is already set in the tunnel flowi6 template via commit 252f3f5a1189 ("ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit path."), simply delete the line setting the incorrect flowi6_proto value.

---
 net/ipv6/ip6_gre.c |    1 -
 1 file changed, 1 deletion(-)
net/ipv6/ip6_gre.c +0 -1
@@ -886,7 +886,6 @@ static int ip6gre_xmit_other(struct sk_b
 		encap_limit = t->parms.encap_limit;
 
 	memcpy(&fl6, &t->fl.u.ip6, sizeof(fl6));
-	fl6.flowi6_proto = skb->protocol;
 
 	err = ip6gre_xmit2(skb, dev, 0, &fl6, encap_limit, &mtu);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ip6_gre-fix-flowi6_proto-value-in-ip6gre_xmit_other.patch