Skip to contentSkip to conversation

Patch "ipv4: disable BH in set_ping_group_range()" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 10, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ipv4: disable BH in set_ping_group_range()

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ipv4-disable-bh-in-set_ping_group_range.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Nov 10 16:43:03 CET 2016

From: Eric Dumazet <[email protected]>
Date: Thu, 20 Oct 2016 10:26:48 -0700
Subject: ipv4: disable BH in set_ping_group_range()

From: Eric Dumazet <[email protected]>

[ Upstream commit a681574c99be23e4d20b769bf0e543239c364af5 ]

In commit 4ee3bd4a8c746 ("ipv4: disable BH when changing ip local port range") Cong added BH protection in set_local_port_range() but missed that same fix was needed in set_ping_group_range()

Fixes b8f1a55639e6 ("udp: Add function to make source port for UDP tunnels")
---
 net/ipv4/sysctl_net_ipv4.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/ipv4/sysctl_net_ipv4.c +2 -2
@@ -109,10 +109,10 @@ static void set_ping_group_range(struct
 	kgid_t *data = table->data;
 	struct net *net =
 		container_of(table->data, struct net, ipv4.ping_group_range.range);
-	write_seqlock(&net->ipv4.ip_local_ports.lock);
+	write_seqlock_bh(&net->ipv4.ip_local_ports.lock);
 	data[0] = low;
 	data[1] = high;
-	write_sequnlock(&net->ipv4.ip_local_ports.lock);
+	write_sequnlock_bh(&net->ipv4.ip_local_ports.lock);
 }
 
 /* Validate changes from /proc interface. */

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/ipv4-use-the-right-lock-for-ping_group_range.patch queue-4.8/ipv4-disable-bh-in-set_ping_group_range.patch queue-4.8/udp-fix-ip_checksum-handling.patch queue-4.8/netlink-do-not-enter-direct-reclaim-from-netlink_dump.patch queue-4.8/ipv6-tcp-restore-ip6cb-for-pktoptions-skbs.patch queue-4.8/packet-on-direct_xmit-limit-tso-and-csum-to-supported-devices.patch queue-4.8/net-pktgen-remove-rcu-locking-in-pktgen_change_name.patch