Patch "dib0700: fix nec repeat handling" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
dib0700: fix nec repeat handling
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
dib0700-fix-nec-repeat-handling.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
ba13e98f2cebd55a3744c5ffaa08f9dca73bf521Mon Sep 17 00:00:00 2001
From: Sean Young <[email protected]>
Date: Thu, 10 Nov 2016 17:44:49 +0100
Subject: dib0700: fix nec repeat handling
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Sean Young <[email protected]>
commit ba13e98f2cebd55a3744c5ffaa08f9dca73bf521 upstream.
When receiving a nec repeat, ensure the correct scancode is repeated rather than a random value from the stack. This removes the need for the bogus uninitialized_var() and also fixes the warnings:
drivers/media/usb/dvb-usb/dib0700_core.c: In function ‘dib0700_rc_urb_completion’:
drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be used uninitialized in this function
[sean addon: So after writing the patch and submitting it, I've bought the
hardware on ebay. Without this patch you get random scancodes on nec repeats, which the patch indeed fixes.]
--- drivers/media/usb/dvb-usb/dib0700_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/media/usb/dvb-usb/dib0700_core.c +3 -2
@@ -677,7 +677,7 @@ static void dib0700_rc_urb_completion(ststruct dvb_usb_device *d = purb->context;struct dib0700_rc_response *poll_reply;enum rc_type protocol; -u32 uninitialized_var (keycode ); +u32 keycode;u8 toggle;deb_info ("%s()\n" , __func__);
@@ -719,7 +719,8 @@ static void dib0700_rc_urb_completion(st poll_reply->nec.data == 0x00 && poll_reply->nec.not_data == 0xff) { poll_reply->data_state =2 ; -break ; +rc_repeat (d->rc_dev); + goto resubmit; }if ((poll_reply->nec.data ^ poll_reply->nec.not_data) !=0xff ) {
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/dib0700-fix-nec-repeat-handling.patch