Skip to contentSkip to conversation

Patch "scsi: scsi_dh_alua: fix missing kref_put() in alua_rtpg_work()" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 15, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

scsi: scsi_dh_alua: fix missing kref_put() in alua_rtpg_work()

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
scsi-scsi_dh_alua-fix-missing-kref_put-in-alua_rtpg_work.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1fdd14279eab2e9f79745631379f0c53cb8f9a5a Mon Sep 17 00:00:00 2001

From: "tang.junhui" <[email protected]>
Date: Fri, 28 Oct 2016 15:54:07 +0800
Subject: scsi: scsi_dh_alua: fix missing kref_put() in alua_rtpg_work()

From: tang.junhui <[email protected]>

commit 1fdd14279eab2e9f79745631379f0c53cb8f9a5a upstream.

Reference count of pg leaks in alua_rtpg_work() since kref_put() is not called to decrease the reference count of pg when the condition pg->rtpg_sdev==NULL satisfied (actually it is easy to satisfy), it would cause memory of pg leakage.

---
 drivers/scsi/device_handler/scsi_dh_alua.c |    1 +
 1 file changed, 1 insertion(+)
drivers/scsi/device_handler/scsi_dh_alua.c +1 -0
@@ -792,6 +792,7 @@ static void alua_rtpg_work(struct work_s
 		WARN_ON(pg->flags & ALUA_PG_RUN_RTPG);
 		WARN_ON(pg->flags & ALUA_PG_RUN_STPG);
 		spin_unlock_irqrestore(&pg->lock, flags);
+		kref_put(&pg->kref, release_port_group);
 		return;
 	}
 	if (pg->flags & ALUA_SYNC_STPG)

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/scsi-scsi_dh_alua-fix-missing-kref_put-in-alua_rtpg_work.patch queue-4.8/scsi-scsi_dh_alua-fix-a-reference-counting-bug.patch