Skip to contentSkip to conversation

] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.

PATCH In review Rodrigo Vivi 4 participants 9 messages Nov 15, 2016 – Nov 28, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.

This commit adding all known marketing names for latest gen9 platforms.

---
 README             |  2 +-
 man/intel.man      |  2 +-
 src/intel_module.c | 29 ++++++++++++++++++++++++++++-
 3 files changed, 30 insertions(+), 3 deletions(-)
README +1 -1
index cf4d88d..e58477d 100644
@@ -15,7 +15,7 @@ Intel graphics chipsets including:
 	G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
 	PineView-M (Atom N400 series)
 	PineView-D (Atom D400/D500 series)
-	Intel(R) HD Graphics: 2000-6000,
+	Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 	Intel(R) Iris(TM) Graphics: 5100/6100, and
 	Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
man/intel.man +1 -1
index 8da496e..16cc5d9 100644
@@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
 G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
 Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
+Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 Intel(R) Iris(TM) Graphics: 5100/6100, and
 Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
src/intel_module.c +28 -1
index e443c9e..86b4aae 100644
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
 	{0x22b2, "HD Graphics"},
 	{0x22b3, "HD Graphics"},
 
+	/* Skylake */
+	{0x1902, "HD Graphics 510"},
+	{0x1906, "HD Graphics 510"},
+	{0x190B, "HD Graphics 510"},
+	{0x1912, "HD Graphics 530"},
+	{0x1916, "HD Graphics 520"},
+	{0x191B, "HD Graphics 530"},
+	{0x191D, "HD Graphics P530"},
+	{0x191E, "HD Graphics 515"},
+	{0x1921, "HD Graphics 520"},
+	{0x1926, "Iris Graphics 540"},
+	{0x1927, "Iris Graphics 550"},
+	{0x192B, "Iris Graphics 555"},
+	{0x192D, "Iris Graphics P555"},
+	{0x1932, "Iris Pro Graphics 580"},
+	{0x193A, "Iris Pro Graphics P580"},
+	{0x193B, "Iris Pro Graphics 580"},
+	{0x193D, "Iris Pro Graphics P580"},
+
+	/* Broxton (Apollolake) */
+	{0x5A84, "HD Graphics 505"},
+	{0x5A85, "HD Graphics 500"},
+
+	/* Kabylake */
+	{0x5916, "HD Graphics 620"},
+	{0x591E, "HD Graphics 615"},
+
 	/* When adding new identifiers, also update:
 	 * 1. intel_identify()
 	 * 2. man/intel.man
@@ -465,7 +492,7 @@ static void intel_identify(int flags)
 	if (unique != stack)
 		free(unique);
 
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
 }
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 75 lines · Rodrigo Vivi

This commit adding all known marketing names for latest gen9 platforms.

---
 README             |  2 +-
 man/intel.man      |  2 +-
 src/intel_module.c | 29 ++++++++++++++++++++++++++++-
 3 files changed, 30 insertions(+), 3 deletions(-)
README +1 -1
index cf4d88d..e58477d 100644
@@ -15,7 +15,7 @@ Intel graphics chipsets including:
 	G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
 	PineView-M (Atom N400 series)
 	PineView-D (Atom D400/D500 series)
-	Intel(R) HD Graphics: 2000-6000,
+	Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 	Intel(R) Iris(TM) Graphics: 5100/6100, and
 	Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
man/intel.man +1 -1
index 8da496e..16cc5d9 100644
@@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
 G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
 Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
+Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 Intel(R) Iris(TM) Graphics: 5100/6100, and
 Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
src/intel_module.c +27 -0
index e443c9e..86b4aae 100644
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
 	{0x22b2, "HD Graphics"},
 	{0x22b3, "HD Graphics"},
 
+	/* Skylake */
+	{0x1902, "HD Graphics 510"},
+	{0x1906, "HD Graphics 510"},
+	{0x190B, "HD Graphics 510"},
+	{0x1912, "HD Graphics 530"},
+	{0x1916, "HD Graphics 520"},
+	{0x191B, "HD Graphics 530"},
+	{0x191D, "HD Graphics P530"},
+	{0x191E, "HD Graphics 515"},
+	{0x1921, "HD Graphics 520"},
+	{0x1926, "Iris Graphics 540"},
+	{0x1927, "Iris Graphics 550"},
+	{0x192B, "Iris Graphics 555"},
+	{0x192D, "Iris Graphics P555"},
+	{0x1932, "Iris Pro Graphics 580"},
+	{0x193A, "Iris Pro Graphics P580"},
+	{0x193B, "Iris Pro Graphics 580"},
+	{0x193D, "Iris Pro Graphics P580"},
+
+	/* Broxton (Apollolake) */
+	{0x5A84, "HD Graphics 505"},
+	{0x5A85, "HD Graphics 500"},
+
+	/* Kabylake */
+	{0x5916, "HD Graphics 620"},
+	{0x591E, "HD Graphics 615"},
+
 	/* When adding new identifiers, also update:
 	 * 1. intel_identify()
 	 * 2. man/intel.man

src/intel_module.c static void intel_identify(int flags) · line 497

Quoted 7 lines
src/intel_module.c +1 -1
@@ -465,7 +492,7 @@ static void intel_identify(int flags)
 	if (unique != stack)
 		free(unique);
 
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");

You missed the Iris & Iris Pro models.

Also, might it make sense to use 5xx, P5xx instead?

Kind regards, David
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 79 lines · David Weinehall
Quoted 78 lines · Rodrigo Vivi

This commit adding all known marketing names for latest gen9 platforms.

---
 README             |  2 +-
 man/intel.man      |  2 +-
 src/intel_module.c | 29 ++++++++++++++++++++++++++++-
 3 files changed, 30 insertions(+), 3 deletions(-)
README +1 -1
index cf4d88d..e58477d 100644
@@ -15,7 +15,7 @@ Intel graphics chipsets including:
 	G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
 	PineView-M (Atom N400 series)
 	PineView-D (Atom D400/D500 series)
-	Intel(R) HD Graphics: 2000-6000,
+	Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 	Intel(R) Iris(TM) Graphics: 5100/6100, and
 	Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
man/intel.man +1 -1
index 8da496e..16cc5d9 100644
@@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
 G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
 Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
+Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 Intel(R) Iris(TM) Graphics: 5100/6100, and
 Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
src/intel_module.c +27 -0
index e443c9e..86b4aae 100644
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
 	{0x22b2, "HD Graphics"},
 	{0x22b3, "HD Graphics"},
 
+	/* Skylake */
+	{0x1902, "HD Graphics 510"},
+	{0x1906, "HD Graphics 510"},
+	{0x190B, "HD Graphics 510"},
+	{0x1912, "HD Graphics 530"},
+	{0x1916, "HD Graphics 520"},
+	{0x191B, "HD Graphics 530"},
+	{0x191D, "HD Graphics P530"},
+	{0x191E, "HD Graphics 515"},
+	{0x1921, "HD Graphics 520"},
+	{0x1926, "Iris Graphics 540"},
+	{0x1927, "Iris Graphics 550"},
+	{0x192B, "Iris Graphics 555"},
+	{0x192D, "Iris Graphics P555"},
+	{0x1932, "Iris Pro Graphics 580"},
+	{0x193A, "Iris Pro Graphics P580"},
+	{0x193B, "Iris Pro Graphics 580"},
+	{0x193D, "Iris Pro Graphics P580"},
+
+	/* Broxton (Apollolake) */
+	{0x5A84, "HD Graphics 505"},
+	{0x5A85, "HD Graphics 500"},
+
+	/* Kabylake */
+	{0x5916, "HD Graphics 620"},
+	{0x591E, "HD Graphics 615"},
+
 	/* When adding new identifiers, also update:
 	 * 1. intel_identify()
 	 * 2. man/intel.man
@@ -465,7 +492,7 @@ static void intel_identify(int flags)
 	if (unique != stack)
 		free(unique);
 
Quoted 6 lines

src/intel_module.c static void intel_identify(int flags) · line 497

Quoted 4 lines
src/intel_module.c +1 -1
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");

You missed the Iris & Iris Pro models.

Thanks

Quoted 2 lines

Also, might it make sense to use 5xx, P5xx instead?

What about ont those generic lists we just kill all numbers and let just:
"
Intel(R) HD Graphics.
Intel(R) Iris(TM) Graphics.
Intel(R) Iris(TM) Pro Graphics.
'
?

Chris?

Quoted 3 lines

Kind regards, David

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 100 lines · Rodrigo Vivi
Quoted 79 lines · David Weinehall
Quoted 78 lines · Rodrigo Vivi

This commit adding all known marketing names for latest gen9 platforms.

---
 README             |  2 +-
 man/intel.man      |  2 +-
 src/intel_module.c | 29 ++++++++++++++++++++++++++++-
 3 files changed, 30 insertions(+), 3 deletions(-)
README +1 -1
index cf4d88d..e58477d 100644
@@ -15,7 +15,7 @@ Intel graphics chipsets including:
 	G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
 	PineView-M (Atom N400 series)
 	PineView-D (Atom D400/D500 series)
-	Intel(R) HD Graphics: 2000-6000,
+	Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 	Intel(R) Iris(TM) Graphics: 5100/6100, and
 	Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
man/intel.man +1 -1
index 8da496e..16cc5d9 100644
@@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
 G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
 Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
+Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 Intel(R) Iris(TM) Graphics: 5100/6100, and
 Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
src/intel_module.c +27 -0
index e443c9e..86b4aae 100644
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
 	{0x22b2, "HD Graphics"},
 	{0x22b3, "HD Graphics"},
 
+	/* Skylake */
+	{0x1902, "HD Graphics 510"},
+	{0x1906, "HD Graphics 510"},
+	{0x190B, "HD Graphics 510"},
+	{0x1912, "HD Graphics 530"},
+	{0x1916, "HD Graphics 520"},
+	{0x191B, "HD Graphics 530"},
+	{0x191D, "HD Graphics P530"},
+	{0x191E, "HD Graphics 515"},
+	{0x1921, "HD Graphics 520"},
+	{0x1926, "Iris Graphics 540"},
+	{0x1927, "Iris Graphics 550"},
+	{0x192B, "Iris Graphics 555"},
+	{0x192D, "Iris Graphics P555"},
+	{0x1932, "Iris Pro Graphics 580"},
+	{0x193A, "Iris Pro Graphics P580"},
+	{0x193B, "Iris Pro Graphics 580"},
+	{0x193D, "Iris Pro Graphics P580"},
+
+	/* Broxton (Apollolake) */
+	{0x5A84, "HD Graphics 505"},
+	{0x5A85, "HD Graphics 500"},
+
+	/* Kabylake */
+	{0x5916, "HD Graphics 620"},
+	{0x591E, "HD Graphics 615"},
+
 	/* When adding new identifiers, also update:
 	 * 1. intel_identify()
 	 * 2. man/intel.man
@@ -465,7 +492,7 @@ static void intel_identify(int flags)
 	if (unique != stack)
 		free(unique);
 
Quoted 6 lines

src/intel_module.c static void intel_identify(int flags) · line 497

Quoted 4 lines
src/intel_module.c +1 -1
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");

You missed the Iris & Iris Pro models.

Thanks

Quoted 2 lines

Also, might it make sense to use 5xx, P5xx instead?

What about ont those generic lists we just kill all numbers and let just:
"
Intel(R) HD Graphics.
Intel(R) Iris(TM) Graphics.
Intel(R) Iris(TM) Pro Graphics.
'
?

Quoted 1 line

Chris?

Seems reasonable, and as demonstrated in the past simply listing everything becomes unwieldy, if not unfathomable, quickly.

I honestly don't think the listing here is the primary source for compatibility info (since to get here means that the driver recognised the chipset anyway). For that we can throw into the catch all case in intel_identify().
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 101 lines · Chris Wilson
Quoted 100 lines · Rodrigo Vivi
Quoted 79 lines · David Weinehall
Quoted 78 lines · Rodrigo Vivi

This commit adding all known marketing names for latest gen9 platforms.

---
 README             |  2 +-
 man/intel.man      |  2 +-
 src/intel_module.c | 29 ++++++++++++++++++++++++++++-
 3 files changed, 30 insertions(+), 3 deletions(-)
README +1 -1
index cf4d88d..e58477d 100644
@@ -15,7 +15,7 @@ Intel graphics chipsets including:
 	G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
 	PineView-M (Atom N400 series)
 	PineView-D (Atom D400/D500 series)
-	Intel(R) HD Graphics: 2000-6000,
+	Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 	Intel(R) Iris(TM) Graphics: 5100/6100, and
 	Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
man/intel.man +1 -1
index 8da496e..16cc5d9 100644
@@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
 G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
 Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
+Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 Intel(R) Iris(TM) Graphics: 5100/6100, and
 Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
src/intel_module.c +27 -0
index e443c9e..86b4aae 100644
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
 	{0x22b2, "HD Graphics"},
 	{0x22b3, "HD Graphics"},
 
+	/* Skylake */
+	{0x1902, "HD Graphics 510"},
+	{0x1906, "HD Graphics 510"},
+	{0x190B, "HD Graphics 510"},
+	{0x1912, "HD Graphics 530"},
+	{0x1916, "HD Graphics 520"},
+	{0x191B, "HD Graphics 530"},
+	{0x191D, "HD Graphics P530"},
+	{0x191E, "HD Graphics 515"},
+	{0x1921, "HD Graphics 520"},
+	{0x1926, "Iris Graphics 540"},
+	{0x1927, "Iris Graphics 550"},
+	{0x192B, "Iris Graphics 555"},
+	{0x192D, "Iris Graphics P555"},
+	{0x1932, "Iris Pro Graphics 580"},
+	{0x193A, "Iris Pro Graphics P580"},
+	{0x193B, "Iris Pro Graphics 580"},
+	{0x193D, "Iris Pro Graphics P580"},
+
+	/* Broxton (Apollolake) */
+	{0x5A84, "HD Graphics 505"},
+	{0x5A85, "HD Graphics 500"},
+
+	/* Kabylake */
+	{0x5916, "HD Graphics 620"},
+	{0x591E, "HD Graphics 615"},
+
 	/* When adding new identifiers, also update:
 	 * 1. intel_identify()
 	 * 2. man/intel.man
@@ -465,7 +492,7 @@ static void intel_identify(int flags)
 	if (unique != stack)
 		free(unique);
 
Quoted 6 lines

src/intel_module.c static void intel_identify(int flags) · line 497

Quoted 4 lines
src/intel_module.c +1 -1
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");

You missed the Iris & Iris Pro models.

Thanks

Quoted 2 lines

Also, might it make sense to use 5xx, P5xx instead?

What about ont those generic lists we just kill all numbers and let just:
"
Intel(R) HD Graphics.
Intel(R) Iris(TM) Graphics.
Intel(R) Iris(TM) Pro Graphics.
'
?

Quoted 7 lines
Quoted 1 line

Chris?

Seems reasonable, and as demonstrated in the past simply listing everything becomes unwieldy, if not unfathomable, quickly.

I honestly don't think the listing here is the primary source for compatibility info

agree

Quoted 2 lines

(since to get here means that the driver recognised
the chipset anyway).

If it is already recognized at this intel_identify point, is it possible to grab the device id and than run on that list and only print the know market name?
or that is better to let there on detect function?

Quoted 2 lines

For that we can throw into the catch all case in
intel_identify().

What do you mean? throw all this list away? or really list everyone here on intel_identify but remove the numbers from other plances?

Quoted 2 lines

-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 121 lines · Rodrigo
Quoted 101 lines · Chris Wilson
Quoted 100 lines · Rodrigo Vivi
Quoted 79 lines · David Weinehall
Quoted 78 lines · Rodrigo Vivi

This commit adding all known marketing names for latest gen9 platforms.

---
 README             |  2 +-
 man/intel.man      |  2 +-
 src/intel_module.c | 29 ++++++++++++++++++++++++++++-
 3 files changed, 30 insertions(+), 3 deletions(-)
README +1 -1
index cf4d88d..e58477d 100644
@@ -15,7 +15,7 @@ Intel graphics chipsets including:
 	G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
 	PineView-M (Atom N400 series)
 	PineView-D (Atom D400/D500 series)
-	Intel(R) HD Graphics: 2000-6000,
+	Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 	Intel(R) Iris(TM) Graphics: 5100/6100, and
 	Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
man/intel.man +1 -1
index 8da496e..16cc5d9 100644
@@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
 G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
 Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
+Intel(R) HD Graphics: 500-6000/P530/P555/P580,
 Intel(R) Iris(TM) Graphics: 5100/6100, and
 Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
 
src/intel_module.c +27 -0
index e443c9e..86b4aae 100644
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
 	{0x22b2, "HD Graphics"},
 	{0x22b3, "HD Graphics"},
 
+	/* Skylake */
+	{0x1902, "HD Graphics 510"},
+	{0x1906, "HD Graphics 510"},
+	{0x190B, "HD Graphics 510"},
+	{0x1912, "HD Graphics 530"},
+	{0x1916, "HD Graphics 520"},
+	{0x191B, "HD Graphics 530"},
+	{0x191D, "HD Graphics P530"},
+	{0x191E, "HD Graphics 515"},
+	{0x1921, "HD Graphics 520"},
+	{0x1926, "Iris Graphics 540"},
+	{0x1927, "Iris Graphics 550"},
+	{0x192B, "Iris Graphics 555"},
+	{0x192D, "Iris Graphics P555"},
+	{0x1932, "Iris Pro Graphics 580"},
+	{0x193A, "Iris Pro Graphics P580"},
+	{0x193B, "Iris Pro Graphics 580"},
+	{0x193D, "Iris Pro Graphics P580"},
+
+	/* Broxton (Apollolake) */
+	{0x5A84, "HD Graphics 505"},
+	{0x5A85, "HD Graphics 500"},
+
+	/* Kabylake */
+	{0x5916, "HD Graphics 620"},
+	{0x591E, "HD Graphics 615"},
+
 	/* When adding new identifiers, also update:
 	 * 1. intel_identify()
 	 * 2. man/intel.man
@@ -465,7 +492,7 @@ static void intel_identify(int flags)
 	if (unique != stack)
 		free(unique);
 
Quoted 6 lines

src/intel_module.c static void intel_identify(int flags) · line 497

Quoted 4 lines
src/intel_module.c +1 -1
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
 	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");

You missed the Iris & Iris Pro models.

Thanks

Quoted 2 lines

Also, might it make sense to use 5xx, P5xx instead?

What about ont those generic lists we just kill all numbers and let just:
"
Intel(R) HD Graphics.
Intel(R) Iris(TM) Graphics.
Intel(R) Iris(TM) Pro Graphics.
'
?

Quoted 7 lines
Quoted 1 line

Chris?

Seems reasonable, and as demonstrated in the past simply listing everything becomes unwieldy, if not unfathomable, quickly.

I honestly don't think the listing here is the primary source for compatibility info

agree

Quoted 2 lines

(since to get here means that the driver recognised
the chipset anyway).

If it is already recognized at this intel_identify point, is it possible to grab the device id and than run on that list and only print the know market name?
or that is better to let there on detect function?

Quoted 5 lines
Quoted 2 lines

For that we can throw into the catch all case in
intel_identify().

What do you mean? throw all this list away? or really list everyone here on intel_identify but remove the numbers from other plances?

Sorry, not intel_identify(), but intel_detect_chipset() prints the exact marketing name if known. It's what to print when it is unknown that worries me most.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

PATCH 1/2 intel: Simplify new platform names.

Modern Intel (R) platforms with integrated graphics comes with common names varying the range numbers. So instead of listing all supported platforms let's start using the generic marketing strings without the numbers.

And for the specific board we list it's actual marketing name if available on detection.

---
 README             | 6 +++---
 man/intel.man      | 6 +++---
 src/intel_module.c | 6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)
README +3 -3
index cf4d88d..348983b 100644
@@ -15,9 +15,9 @@ Intel graphics chipsets including:
 	G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
 	PineView-M (Atom N400 series)
 	PineView-D (Atom D400/D500 series)
-	Intel(R) HD Graphics: 2000-6000,
-	Intel(R) Iris(TM) Graphics: 5100/6100, and
-	Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
+	Intel(R) HD Graphics,
+	Intel(R) Iris(TM) Graphics,
+	Intel(R) Iris(TM) Pro Graphics.
 
 Where to get more information about the driver
 ----------------------------------------------
man/intel.man +3 -3
index 8da496e..be398fb 100644
@@ -27,9 +27,9 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
 G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
 Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
-Intel(R) Iris(TM) Graphics: 5100/6100, and
-Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
+Intel(R) HD Graphics,
+Intel(R) Iris(TM) Graphics,
+Intel(R) Iris(TM) Pro Graphics.
 
 .SH CONFIGURATION DETAILS
 Please refer to __xconfigfile__(__filemansuffix__) for general configuration
src/intel_module.c +3 -3
index e443c9e..aeec685 100644
@@ -465,9 +465,9 @@ static void intel_identify(int flags)
 	if (unique != stack)
 		free(unique);
 
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
-	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics\n");
+	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics\n");
 }
 
 static Bool intel_driver_func(ScrnInfoPtr pScrn,
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

PATCH 2/2 intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.

This commit adding all known marketing names for latest gen9 platforms.

v2: On top of simplified generic string names.

---
 src/intel_module.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
src/intel_module.c +27 -0
index aeec685..f15a4c0 100644
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
 	{0x22b2, "HD Graphics"},
 	{0x22b3, "HD Graphics"},
 
+	/* Skylake */
+	{0x1902, "HD Graphics 510"},
+	{0x1906, "HD Graphics 510"},
+	{0x190B, "HD Graphics 510"},
+	{0x1912, "HD Graphics 530"},
+	{0x1916, "HD Graphics 520"},
+	{0x191B, "HD Graphics 530"},
+	{0x191D, "HD Graphics P530"},
+	{0x191E, "HD Graphics 515"},
+	{0x1921, "HD Graphics 520"},
+	{0x1926, "Iris Graphics 540"},
+	{0x1927, "Iris Graphics 550"},
+	{0x192B, "Iris Graphics 555"},
+	{0x192D, "Iris Graphics P555"},
+	{0x1932, "Iris Pro Graphics 580"},
+	{0x193A, "Iris Pro Graphics P580"},
+	{0x193B, "Iris Pro Graphics 580"},
+	{0x193D, "Iris Pro Graphics P580"},
+
+	/* Broxton (Apollolake) */
+	{0x5A84, "HD Graphics 505"},
+	{0x5A85, "HD Graphics 500"},
+
+	/* Kabylake */
+	{0x5916, "HD Graphics 620"},
+	{0x591E, "HD Graphics 615"},
+
 	/* When adding new identifiers, also update:
 	 * 1. intel_identify()
 	 * 2. man/intel.man
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

Re: [PATCH ddx 2/2] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.

Chris,

any comments?
what is still missing?

Thanks,
Rodrigo.

Quoted 55 lines · Rodrigo Vivi

This commit adding all known marketing names for latest gen9 platforms.

v2: On top of simplified generic string names.

---
 src/intel_module.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
src/intel_module.c +27 -1
index aeec685..f15a4c0 100644
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
        {0x22b2, "HD Graphics"},
        {0x22b3, "HD Graphics"},
 
+       /* Skylake */
+       {0x1902, "HD Graphics 510"},
+       {0x1906, "HD Graphics 510"},
+       {0x190B, "HD Graphics 510"},
+       {0x1912, "HD Graphics 530"},
+       {0x1916, "HD Graphics 520"},
+       {0x191B, "HD Graphics 530"},
+       {0x191D, "HD Graphics P530"},
+       {0x191E, "HD Graphics 515"},
+       {0x1921, "HD Graphics 520"},
+       {0x1926, "Iris Graphics 540"},
+       {0x1927, "Iris Graphics 550"},
+       {0x192B, "Iris Graphics 555"},
+       {0x192D, "Iris Graphics P555"},
+       {0x1932, "Iris Pro Graphics 580"},
+       {0x193A, "Iris Pro Graphics P580"},
+       {0x193B, "Iris Pro Graphics 580"},
+       {0x193D, "Iris Pro Graphics P580"},
+
+       /* Broxton (Apollolake) */
+       {0x5A84, "HD Graphics 505"},
+       {0x5A85, "HD Graphics 500"},
+
+       /* Kabylake */
+       {0x5916, "HD Graphics 620"},
+       {0x591E, "HD Graphics 615"},
+
        /* When adding new identifiers, also update:
         * 1. intel_identify()
         * 2. man/intel.man
--

1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx