Skip to contentSkip to conversation

Unbreak windows build

PATCH In review Selva Nair 2 participants 2 messages Nov 16, 2016

lore
Share & tools
lore

Selva Nair

author
#0 lore raw

PATCH 1/1 Unbreak windows build

S_IRWXG, S_IRWXO are not defined in mingw headers. Anyway these bits are not defined in st_mode on Windows, so just skip the test.

---
 src/openvpn/options.c | 2 ++
 1 file changed, 2 insertions(+)
src/openvpn/options.c +2 -0
index e88aa95..44402a9 100644
@@ -2738,11 +2738,13 @@ check_file_access(const int type, const char *file, const int mode, const char *
 	{
 	  msg (M_WARN | M_ERRNO, "WARNING: cannot stat file '%s'", file);
 	}
+#ifndef _WIN32
       else
 	{
 	  if (st.st_mode & (S_IRWXG|S_IRWXO))
 	    msg (M_WARN, "WARNING: file '%s' is group or others accessible", file);
 	}
+#endif
     }
 
   /* Scream if an error is found */
Signature · 1 line
2.1.4
#1 lore raw

ACK, thanks.

Your patch has been applied to the master branch.

commit 7aea4901034c436a539a997b6a504c009496f6f5

Author: Selva Nair
Date:   Wed Nov 16 13:23:13 2016 -0500
     Unbreak windows build

     Signed-off-by: Selva Nair <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg13100.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering