Skip to contentSkip to conversation

Patch "ASoC: Intel: Skylake: Always acquire runtime pm ref on unload" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 17, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ASoC: Intel: Skylake: Always acquire runtime pm ref on unload

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
asoc-intel-skylake-always-acquire-runtime-pm-ref-on-unload.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6d13f62d931ba638e54ba56f3a7dd3080ffb485a Mon Sep 17 00:00:00 2001

From: Lukas Wunner <[email protected]>
Date: Thu, 20 Oct 2016 12:26:16 +0200
Subject: ASoC: Intel: Skylake: Always acquire runtime pm ref on unload

From: Lukas Wunner <[email protected]>

commit 6d13f62d931ba638e54ba56f3a7dd3080ffb485a upstream.

skl_probe() releases a runtime pm ref unconditionally wheras skl_remove() acquires one only if the device is wakeup capable. Thus if the device is not wakeup capable, unloading and reloading the module will result in the refcount being decreased below 0. Fix it.

Fixes d8c2dab8381d ("ASoC: Intel: Add Skylake HDA audio driver")
---
 sound/soc/intel/skylake/skl.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/intel/skylake/skl.c +1 -2
@@ -785,8 +785,7 @@ static void skl_remove(struct pci_dev *p
 
 	release_firmware(skl->tplg);
 
-	if (pci_dev_run_wake(pci))
-		pm_runtime_get_noresume(&pci->dev);
+	pm_runtime_get_noresume(&pci->dev);
 
 	/* codec removal, invoke bus_device_remove */
 	snd_hdac_ext_bus_device_remove(ebus);

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/asoc-intel-skylake-always-acquire-runtime-pm-ref-on-unload.patch