Skip to contentSkip to conversation

chromium: Fix ILL_ILLOPN signal in sandbox

PATCH Superseded Davis, Michael 2 participants 2 messages Nov 18, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 chromium: Fix ILL_ILLOPN signal in sandbox

Fix Aw Snap! error when running chromium 52 in Morty with sandbox enabled.

---
 .../chromium/chromium/chromium/unset-madv-free.patch      | 15 +++++++++++++++
 recipes-browser/chromium/chromium_52.0.2743.76.bb         |  1 +
 2 files changed, 16 insertions(+)
 create mode 100644 recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
recipes-browser/chromium/chromium/chromium/unset-madv-free.patch new file +15 -0
new file mode 100644
index 0000000..15d4982
@@ -0,0 +1,15 @@
+diff -Naur chromium-52.0.2743.76/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp chromium-52.0.2743.76b/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp
+--- chromium-52.0.2743.76/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp	2016-07-15 17:02:49.000000000 -0500
++++ chromium-52.0.2743.76b/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp	2016-11-18 09:13:01.109731385 -0600
+@@ -41,6 +41,11 @@
+ #include <errno.h>
+ #include <sys/mman.h>
+ 
++#if OS(LINUX) && defined(MADV_FREE)
++// Added in Linux 4.5, but it breaks the sandbox.
++#undef MADV_FREE
++#endif
++
+ #ifndef MADV_FREE
+ #define MADV_FREE MADV_DONTNEED
+ #endif
recipes-browser/chromium/chromium_52.0.2743.76.bb +1 -0
index 14b519c..5be3c32 100644
@@ -9,6 +9,7 @@ SRC_URI += "\
         file://0005-Override-root-filesystem-access-restriction.patch \
         file://chromium/0011-Replace-readdir_r-with-readdir.patch \
         file://chromium/remove-Werror.patch \
+        file://chromium/unset-madv-free.patch \
         ${@bb.utils.contains('PACKAGECONFIG', 'component-build', 'file://component-build.gypi', '', d)} \
         ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', 'file://0001-Remove-accelerated-Canvas-support-from-blacklist.patch', '', d)} \
 "
Signature · 1 line
2.5.5
#1 lore raw
Quoted 2 lines · Michael

Fix Aw Snap! error when running chromium 52 in Morty with sandbox enabled.

The patch is fine. However, this issue is seen in qtwebengine few moths ago please add references to the commit so we can track this patch with future upgrades .e.g.

http://code.qt.io/cgit/qt/qtwebengine-chromium.git/commit/?h=49-based&id=b12ffcd411d4776f7120ccecb3be34344d930d2b

Quoted 41 lines
---
 .../chromium/chromium/chromium/unset-madv-free.patch      | 15 +++++++++++++++
 recipes-browser/chromium/chromium_52.0.2743.76.bb         |  1 +
 2 files changed, 16 insertions(+)
 create mode 100644 recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
recipes-browser/chromium/chromium/chromium/unset-madv-free.patch new file +15 -0
new file mode 100644
index 0000000..15d4982
@@ -0,0 +1,15 @@
+diff -Naur chromium-52.0.2743.76/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp chromium-52.0.2743.76b/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp
+--- chromium-52.0.2743.76/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp	2016-07-15 17:02:49.000000000 -0500
++++ chromium-52.0.2743.76b/third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp	2016-11-18 09:13:01.109731385 -0600
+@@ -41,6 +41,11 @@
+ #include <errno.h>
+ #include <sys/mman.h>
+ 
++#if OS(LINUX) && defined(MADV_FREE)
++// Added in Linux 4.5, but it breaks the sandbox.
++#undef MADV_FREE
++#endif
++
+ #ifndef MADV_FREE
+ #define MADV_FREE MADV_DONTNEED
+ #endif
recipes-browser/chromium/chromium_52.0.2743.76.bb +1 -0
index 14b519c..5be3c32 100644
@@ -9,6 +9,7 @@ SRC_URI += "\
         file://0005-Override-root-filesystem-access-restriction.patch \
         file://chromium/0011-Replace-readdir_r-with-readdir.patch \
         file://chromium/remove-Werror.patch \
+        file://chromium/unset-madv-free.patch \
         ${@bb.utils.contains('PACKAGECONFIG', 'component-build', 'file://component-build.gypi', '', d)} \
         ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', 'file://0001-Remove-accelerated-Canvas-support-from-blacklist.patch', '', d)} \
 "