Skip to contentSkip to conversation

staging: speakup: checkpatch modifications

PATCH In review Walt Feasel 2 participants 5 messages Nov 19, 2016 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover staging: speakup: checkpatch modifications

Make Linux kernel style modifications for speakup to include:

Comment style modifications
Align parenthesis
Correct email in TODO

Walt Feasel (3):
staging: speakup: varhandlers.c Comment style modifications
staging: speakup: varhandlers.c Align parenthesis
staging: speakup: TODO Correct email

 drivers/staging/speakup/TODO          | 2 +-
 drivers/staging/speakup/varhandlers.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 2 lines
v2 makes changes to correct for email format patch submission
2.1.4
#1 lore raw

PATCH v2 1/3 staging: speakup: varhandlers.c Comment style modifications

Make modifications to comment style

---
v2 makes changes to correct for email format patch submission

 drivers/staging/speakup/varhandlers.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/speakup/varhandlers.c +2 -1
index 21186e3..5ab7245 100644
@@ -266,7 +266,8 @@ int spk_set_string_var(const char *page, struct st_var_header *var, int len)
 	return 0;
 }
 
-/* spk_set_mask_bits sets or clears the punc/delim/repeat bits,
+/*
+ * spk_set_mask_bits sets or clears the punc/delim/repeat bits,
  * if input is null uses the defaults.
  * values for how: 0 clears bits of chars supplied,
  * 1 clears allk, 2 sets bits for chars
Signature · 1 line
2.1.4
#2 lore raw

PATCH v2 2/3 staging: speakup: varhandlers.c Align parenthesis

In reply to Walt Feasel

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

---
v2 makes changes to correct for email format patch submission

 drivers/staging/speakup/varhandlers.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/speakup/varhandlers.c +1 -2
index 5ab7245..cc98419 100644
@@ -237,8 +237,7 @@ int spk_set_num_var(int input, struct st_var_header *var, int how)
 	if (!var_data->u.n.out_str)
 		l = sprintf(cp, var_data->u.n.synth_fmt, (int)val);
 	else
-		l = sprintf(cp,
-			var_data->u.n.synth_fmt, var_data->u.n.out_str[val]);
+		l = sprintf(cp,	var_data->u.n.synth_fmt, var_data->u.n.out_str[val]);
 	synth_printf("%s", cp);
 	return 0;
 }
Signature · 1 line
2.1.4
#3 lore raw

PATCH v2 3/3 staging: speakup: TODO Correct email

In reply to Walt Feasel

Make email correction for [email protected]

---
v2 makes changes to correct for email format patch submission

 drivers/staging/speakup/TODO | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/TODO +1 -1
index 3094799..993410c 100644
@@ -42,6 +42,6 @@ We prefer that you contact us on the mailing list; however, if you do
 not want to subscribe to a mailing list, send your email to all of the
 following:
 
[email protected], [email protected], [email protected] and
[email protected], [email protected], [email protected] and
 [email protected].
 
Signature · 1 line
2.1.4
Acked-by on v2 3/3
#4 lore raw

Re: [PATCH v2 3/3] staging: speakup: TODO Correct email

Quoted 3 lines · Walt Feasel

Make email correction for [email protected]

Quoted 17 lines

---
v2 makes changes to correct for email format patch submission

 drivers/staging/speakup/TODO | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/TODO +1 -1
index 3094799..993410c 100644
@@ -42,6 +42,6 @@ We prefer that you contact us on the mailing list; however, if you do
 not want to subscribe to a mailing list, send your email to all of the
 following:
 
[email protected], [email protected], [email protected] and
[email protected], [email protected], [email protected] and
 [email protected].