Skip to contentSkip to conversation

Patch "ALSA: hda - Fix mic regression by ASRock mobo fixup" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 21, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: hda - Fix mic regression by ASRock mobo fixup

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-hda-fix-mic-regression-by-asrock-mobo-fixup.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9a2541910dc7eaaa6859eea8a0ffda673059a623 Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Fri, 11 Nov 2016 12:33:20 +0100
Subject: ALSA: hda - Fix mic regression by ASRock mobo fixup

From: Takashi Iwai <[email protected]>

commit 9a2541910dc7eaaa6859eea8a0ffda673059a623 upstream.

The commit [1a3f099101b8: ALSA: hda - Fix surround output pins for ASRock B150M mobo] introduced a fixup of pin configs for ASRock mobos to fix the surround outputs. However, this overrides the pin configs of the mic pins as if they are outputs-only, effectively disabling the mic inputs. Of course, it's a regression wrt mic functionality.

Actually the pins 0x18 and 0x1a don't need to be changed; we just need to disable the bogus pins 0x14 and 0x15. Then the auto-parser will pick up mic pins as switchable and assign the surround outputs there.

This patch removes the incorrect pin overrides of NID 0x18 and 0x1a from the ASRock fixup.

Fixes 1a3f099101b8 ('ALSA: hda - Fix surround output pins for ASRock...')
Reported-and-tested-by Vitor Antunes <[email protected]>

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=187431

---
 sound/pci/hda/patch_realtek.c |    2 --
 1 file changed, 2 deletions(-)
sound/pci/hda/patch_realtek.c +0 -2
@@ -6905,8 +6905,6 @@ static const struct hda_fixup alc662_fix
 		.v.pins = (const struct hda_pintbl[]) {
 			{ 0x15, 0x40f000f0 }, /* disabled */
 			{ 0x16, 0x40f000f0 }, /* disabled */
-			{ 0x18, 0x01014011 }, /* LO */
-			{ 0x1a, 0x01014012 }, /* LO */
 			{ }
 		}
 	},

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/alsa-hda-fix-mic-regression-by-asrock-mobo-fixup.patch queue-4.8/alsa-usb-audio-fix-use-after-free-of-usb_device-at-disconnect.patch queue-4.8/alsa-hda-add-a-new-condition-to-check-if-it-is-thinkpad.patch