drm/i915: Remove plane config from intel_dump_pipe_config
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/1 drm/i915: Remove plane config from intel_dump_pipe_config
From: Tvrtko Ursulin <[email protected]>
I am told the way it is done is not safe.
--- drivers/gpu/drm/i915/intel_display.c | 38 +----------------------------------- 1 file changed, 1 insertion(+), 37 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -37
@@ -12729,12 +12729,7 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,struct intel_crtc_state *pipe_config, const char *context) { - struct drm_device *dev = crtc->base.dev; -struct drm_i915_private *dev_priv =to_i915 (dev); -struct drm_plane *plane; -struct intel_plane *intel_plane; -struct intel_plane_state *state; -struct drm_framebuffer *fb; + struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);DRM_DEBUG_KMS ("[CRTC:%d:%s]%s\n" , crtc->base.base.id, crtc->base.name, context);
@@ -12822,37 +12817,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, pipe_config->dpll_hw_state.fp0, pipe_config->dpll_hw_state.fp1); } - -DRM_DEBUG_KMS ("planes on this crtc\n" ); -list_for_each_entry (plane, &dev->mode_config.plane_list, head) { -struct drm_format_name_buf format_name; - intel_plane =to_intel_plane (plane); -if (intel_plane->pipe != crtc->pipe) -continue ; - - state =to_intel_plane_state (plane->state); - fb = state->base.fb; -if (!fb) { -DRM_DEBUG_KMS ("[PLANE:%d:%s] disabled, scaler_id = %d\n" , - plane->base.id, plane->name, state->scaler_id); -continue ; - } - -DRM_DEBUG_KMS ("[PLANE:%d:%s] FB:%d, fb = %ux%u format = %s\n" , - plane->base.id, plane->name, - fb->base.id, fb->width, fb->height, -drm_get_format_name (fb->pixel_format, &format_name)); -if (INTEL_GEN (dev_priv) >=9 ) -DRM_DEBUG_KMS ("\tscaler:%d src %dx%d+%d+%d dst %dx%d+%d+%d\n" , - state->scaler_id, - state->base.src.x1 >>16 , - state->base.src.y1 >>16 , -drm_rect_width (&state->base.src) >>16 , -drm_rect_height (&state->base.src) >>16 , - state->base.dst.x1, state->base.dst.y1, -drm_rect_width (&state->base.dst), -drm_rect_height (&state->base.dst)); - } }static bool check_digital_port_conflicts (struct drm_atomic_state *state)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for drm/i915: Remove plane config from intel_dump_pipe_config
== Series Details ==
== Series Details ==
Series: drm/i915: Remove plane config from intel_dump_pipe_config
URL : https://patchwork.freedesktop.org/series/15650/
State : warning
== Summary ==
Series 15650v1 drm/i915: Remove plane config from intel_dump_pipe_config
https://patchwork.freedesktop.org/api/1.0/series/15650/revisions/1/mbox/
Test kms_force_connector_basic:
Subgroup force-load-detect:
pass -> DMESG-WARN (fi-snb-2520m)fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40 fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32 fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20 fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20 fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53 fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21 fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-snb-2520m total:244 pass:211 dwarn:1 dfail:0 fail:0 skip:32 fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
d6149d212b69a8e1d9229fe80fca034a0abe1d0e drm-intel-nightly: 2016y-11m-21d-12h-48m-13s UTC integration manifest 0d588c0 drm/i915: Remove plane config from intel_dump_pipe_config
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3068/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx