Skip to contentSkip to conversation

staging: speakup: speakup_txprt.c checkpatch modifications

PATCH New Walt Feasel 1 participant 3 messages Nov 21, 2016 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover staging: speakup: speakup_txprt.c checkpatch modifications

Make Linux kernel style modifications to speakup-txprt.c to include:

Comment modifications
Spaces preferred around operator

Walt Feasel (2):
staging: speakup: speakup_txprt.c Comment modifications
staging: speakup: speakup_txprt.c Spaces preferred around operator

 drivers/staging/speakup/speakup_txprt.c | 29 ++++++++++++++---------------
 1 file changed, 14 insertions(+), 15 deletions(-)

--
v2 makes changes to correct for email format patch submission

2.1.4

#1 lore raw

PATCH v2 1/2 staging: speakup: speakup_txprt.c Comment modifications

Make modifications to comments

---
v2 makes changes to correct for email format patch submission

 drivers/staging/speakup/speakup_txprt.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/speakup/speakup_txprt.c +3 -4
index fd98d4f..57feffa 100644
@@ -1,6 +1,6 @@
 /*
  * originally written by: Kirk Reiser <[email protected]>
-* this version considerably modified by David Borowski, [email protected]
+ * this version considerably modified by David Borowski, [email protected]
  *
  * Copyright (C) 1998-99  Kirk Reiser.
  * Copyright (C) 2003 David Borowski.
@@ -36,9 +36,8 @@ static struct var_t vars[] = {
 	V_LAST_VAR
 	 };
 
-/*
- * These attributes will appear in /sys/accessibility/speakup/txprt.
- */
+/* These attributes will appear in /sys/accessibility/speakup/txprt. */
+
 static struct kobj_attribute caps_start_attribute =
 	__ATTR(caps_start, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute caps_stop_attribute =
Signature · 1 line
2.1.4
#2 lore raw

PATCH v2 2/2 staging: speakup: speakup_txprt.c Spaces preferred around operator

In reply to Walt Feasel

Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'

---
v2 makes changes to correct for email format patch submission

 drivers/staging/speakup/speakup_txprt.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/speakup/speakup_txprt.c +11 -11
index 57feffa..b3d2cfd 100644
@@ -39,28 +39,28 @@ static struct var_t vars[] = {
 /* These attributes will appear in /sys/accessibility/speakup/txprt. */
 
 static struct kobj_attribute caps_start_attribute =
-	__ATTR(caps_start, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(caps_start, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute caps_stop_attribute =
-	__ATTR(caps_stop, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(caps_stop, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute pitch_attribute =
-	__ATTR(pitch, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(pitch, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute rate_attribute =
-	__ATTR(rate, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(rate, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute tone_attribute =
-	__ATTR(tone, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(tone, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute vol_attribute =
-	__ATTR(vol, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(vol, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 
 static struct kobj_attribute delay_time_attribute =
-	__ATTR(delay_time, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(delay_time, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute direct_attribute =
-	__ATTR(direct, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(direct, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute full_time_attribute =
-	__ATTR(full_time, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(full_time, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute jiffy_delta_attribute =
-	__ATTR(jiffy_delta, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(jiffy_delta, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 static struct kobj_attribute trigger_time_attribute =
-	__ATTR(trigger_time, S_IWUSR|S_IRUGO, spk_var_show, spk_var_store);
+	__ATTR(trigger_time, S_IWUSR | S_IRUGO, spk_var_show, spk_var_store);
 
 /*
  * Create a group of attributes so that we can create and destroy them all
Signature · 1 line
2.1.4