fsl/usb: enable the errata-a005697 for ls1012a

PATCH New Changming Huang 2 participants 5 messages Nov 24, 2016 – Dec 1, 2016 USB

lore

Share & tools

lore

Changming Huang

author

2016-11-24 07:14 UTC #0 lore raw

PATCH 1/1 fsl/usb: enable the errata-a005697 for ls1012a

Enable the errata-a005697 for ls1012a

Signed-off-by Changming Huang <[email protected]>

---
 drivers/usb/common/fsl-errata.c |    4 ++++
 1 file changed, 4 insertions(+)

drivers/usb/common/fsl-errata.c +4 -0

index 0dc3dd8..59a69a1 100644
@@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
 	case SVR_9132:
 		return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1);
 #endif
+#ifdef CONFIG_ARM
+	case SVR_LS1012A:
+		return IS_SVR_REV(svr, 1, 0);
+#endif
 	}
 	return false;
 }

Signature · 1 line

1.7.9.5

Jerry Huang

author

2016-11-30 02:39 UTC #1 lore raw

PATCH 1/1 fsl/usb: enable the errata-a005697 for ls1012a

Any comment for this patch?

Best Regards
Jerry Huang

-----Original Message-----
From: Changming Huang [mailto:jerry.huang at nxp.com]
Sent: Thursday, November 24, 2016 3:14 PM
To: york sun <[email protected]>; u-boot at lists.denx.de
Cc: Jerry Huang <[email protected]>
Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a

Enable the errata-a005697 for ls1012a

Signed-off-by Changming Huang <[email protected]>

---
 drivers/usb/common/fsl-errata.c |    4 ++++
 1 file changed, 4 insertions(+)

drivers/usb/common/fsl-errata.c +4 -1

@@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
 	case SVR_9132:
 		return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1);  #endif
+#ifdef CONFIG_ARM
+	case SVR_LS1012A:
+		return IS_SVR_REV(svr, 1, 0);
+#endif
 	}
 	return false;
 }
--

1.7.9.5

york sun

2016-11-30 05:09 UTC #2 lore raw

PATCH 1/1 fsl/usb: enable the errata-a005697 for ls1012a

Quoted 2 lines · Jerry Huang

Any comment for this patch?

Looks simple enough.

York

Quoted 34 lines

Best Regards
Jerry Huang
-----Original Message-----
From: Changming Huang [mailto:jerry.huang at nxp.com]
Sent: Thursday, November 24, 2016 3:14 PM
To: york sun <[email protected]>; u-boot at lists.denx.de
Cc: Jerry Huang <[email protected]>
Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by Changming Huang <[email protected]>
---
 drivers/usb/common/fsl-errata.c |    4 ++++
 1 file changed, 4 insertions(+)
drivers/usb/common/fsl-errata.c +4 -1
@@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
 	case SVR_9132:
 		return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1);  #endif
+#ifdef CONFIG_ARM
+	case SVR_LS1012A:
+		return IS_SVR_REV(svr, 1, 0);
+#endif
 	}
 	return false;
 }
--
1.7.9.5

york sun

2016-11-30 19:09 UTC #3 lore raw

PATCH 1/1 fsl/usb: enable the errata-a005697 for ls1012a

In reply to Jerry Huang

Quoted 23 lines · Jerry Huang

Any comment for this patch?
Best Regards
Jerry Huang
-----Original Message-----
From: Changming Huang [mailto:jerry.huang at nxp.com]
Sent: Thursday, November 24, 2016 3:14 PM
To: york sun <[email protected]>; u-boot at lists.denx.de
Cc: Jerry Huang <[email protected]>
Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by Changming Huang <[email protected]>
---
 drivers/usb/common/fsl-errata.c |    4 ++++
 1 file changed, 4 insertions(+)

drivers/usb/common/fsl-errata.c bool has_erratum_a005697(void) · line 145

Quoted 7 lines

drivers/usb/common/fsl-errata.c +4 -0

@@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
 	case SVR_9132:
 		return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1);  #endif
+#ifdef CONFIG_ARM
+	case SVR_LS1012A:
+		return IS_SVR_REV(svr, 1, 0);
+#endif
 	}

Actually this patch has a problem with the SVR. SVR_LS1012A is defined in arch/arm/include/asm/arch-fsl-layerscape/soc.h. You will see compiling errors for LS1021A, eg ls1021atwr_nor.

York

Jerry Huang

author

2016-12-01 03:27 UTC #4 lore raw

PATCH 1/1 fsl/usb: enable the errata-a005697 for ls1012a

York,
I don't know the file " arch/arm/include/asm/arch-fsl-layerscape/soc.h " is not included for ls1021a, maybe ls1021a is one special ARM SoC. Now I will add one macro " CONFIG_LS1012A " to resolve this issue.

Best Regards
Jerry Huang

-----Original Message-----
From: york sun
Sent: Thursday, December 01, 2016 3:10 AM
To: Jerry Huang <[email protected]>; u-boot at lists.denx.de
Subject: Re: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a

Quoted 24 lines · Jerry Huang

Any comment for this patch?
Best Regards
Jerry Huang
-----Original Message-----
From: Changming Huang [mailto:jerry.huang at nxp.com]
Sent: Thursday, November 24, 2016 3:14 PM
To: york sun <[email protected]>; u-boot at lists.denx.de
Cc: Jerry Huang <[email protected]>
Subject: [PATCH] fsl/usb: enable the errata-a005697 for ls1012a
Enable the errata-a005697 for ls1012a
Signed-off-by Changming Huang <[email protected]>
---
 drivers/usb/common/fsl-errata.c |    4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0
b/drivers/usb/common/fsl-errata.c index 0dc3dd8..59a69a1 100644

drivers/usb/common/fsl-errata.c bool has_erratum_a005697(void) · line 145

Quoted 7 lines

drivers/usb/common/fsl-errata.c +4 -0

@@ -139,6 +139,10 @@ bool has_erratum_a005697(void)
 	case SVR_9132:
 		return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1);  #endif
+#ifdef CONFIG_ARM
+	case SVR_LS1012A:
+		return IS_SVR_REV(svr, 1, 0);
+#endif
 	}

Actually this patch has a problem with the SVR. SVR_LS1012A is defined in arch/arm/include/asm/arch-fsl-layerscape/soc.h. You will see compiling errors for LS1021A, eg ls1021atwr_nor.

York