Skip to contentSkip to conversation

drm/amdgpu: fix bug uvd status not true in debugfs.

PATCH In review Rex Zhu 3 participants 3 messages Nov 25, 2016 – Nov 26, 2016 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Rex Zhu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: fix bug uvd status not true in debugfs.

can't get uvd's state by uvd_enabled. uvd_enabled is used for request higher mclk.
in multi-display case, mclk has been in highest clock, no matter uvd's state changed, uvd_enabled will not be changed.

Change-Id Iedbe3b7ce085e9199fa7fddb88185bfd16f26612
---
 drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/ci_dpm.c +1 -1
index 1027f92..bda9e3d 100644
@@ -6083,7 +6083,7 @@ ci_dpm_debugfs_print_current_performance_level(struct amdgpu_device *adev,
 		activity_percent = activity_percent > 100 ? 100 : activity_percent;
 	}
 
-	seq_printf(m, "uvd %sabled\n", pi->uvd_enabled ? "en" : "dis");
+	seq_printf(m, "uvd %sabled\n", pi->uvd_power_gated ? "dis" : "en");
 	seq_printf(m, "vce %sabled\n", rps->vce_active ? "en" : "dis");
 	seq_printf(m, "power level avg    sclk: %u mclk: %u\n",
 		   sclk, mclk);
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1480073981-6561-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 8 lines · Rex Zhu

can't get uvd's state by uvd_enabled. uvd_enabled is used for request higher mclk.
in multi-display case, mclk has been in highest clock, no matter uvd's state changed, uvd_enabled will not be changed.

Change-Id Iedbe3b7ce085e9199fa7fddb88185bfd16f26612
Quoted 20 lines
---
 drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/ci_dpm.c +1 -2
index 1027f92..bda9e3d 100644
@@ -6083,7 +6083,7 @@ ci_dpm_debugfs_print_current_performance_level(struct amdgpu_device *adev,
                activity_percent = activity_percent > 100 ? 100 : activity_percent;
        }
 
-       seq_printf(m, "uvd %sabled\n", pi->uvd_enabled ? "en" : "dis");
+       seq_printf(m, "uvd %sabled\n", pi->uvd_power_gated ? "dis" : "en");
        seq_printf(m, "vce %sabled\n", rps->vce_active ? "en" : "dis");
        seq_printf(m, "power level avg    sclk: %u mclk: %u\n",
                   sclk, mclk);
--

1.9.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CADnq5_NAHDDvSjKWLDqeXOFASUnN7BFpWjCTa0bpEgZbqDjNog-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Reviewed-by Alex Deucher
#4 lore raw

Keep in mind this is the older "method" since SI and up have a unified pm_status.

Tom

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Alex Deucher <[email protected]>
Sent: Friday, November 25, 2016 18:30
To: Zhu, Rex
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amdgpu: fix bug uvd status not true in debugfs.

Quoted 8 lines · Rex Zhu

can't get uvd's state by uvd_enabled. uvd_enabled is used for request higher mclk.
in multi-display case, mclk has been in highest clock, no matter uvd's state changed, uvd_enabled will not be changed.

Change-Id Iedbe3b7ce085e9199fa7fddb88185bfd16f26612
Quoted 20 lines
---
 drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/ci_dpm.c +1 -2
index 1027f92..bda9e3d 100644
@@ -6083,7 +6083,7 @@ ci_dpm_debugfs_print_current_performance_level(struct amdgpu_device *adev,
                activity_percent = activity_percent > 100 ? 100 : activity_percent;
        }
 
-       seq_printf(m, "uvd %sabled\n", pi->uvd_enabled ? "en" : "dis");
+       seq_printf(m, "uvd %sabled\n", pi->uvd_power_gated ? "dis" : "en");
        seq_printf(m, "vce %sabled\n", rps->vce_active ? "en" : "dis");
        seq_printf(m, "power level avg    sclk: %u mclk: %u\n",
                   sclk, mclk);
--

1.9.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx