Skip to contentSkip to conversation

usb: return correct errno on failures

PATCH New Pan Bian 1 participant 1 message Nov 29, 2016 USB

lore
Share & tools
lore

Pan Bian

author
#0 lore raw

PATCH 1/1 usb: return correct errno on failures

In function __wa_xfer_setup_segs(), variable result takes the return value. Its value should be a negative errno on failures. Because result may be reassigned in a loop, and its value is guaranteed to be not less than 0 during the following repeats of the loop. So when the call to kmalloc() or usb_alloc_urb() fails in the loop, the value of variable result may be 0 (indicates no error), which is inconsistent with the execution status. This patch fixes the bug, initializing variable result with -ENOMEM in the loop.

---
 drivers/usb/wusbcore/wa-xfer.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/wusbcore/wa-xfer.c +1 -0
index 167fcc71..e70322b 100644
@@ -1203,6 +1203,7 @@ static int __wa_xfer_setup_segs(struct wa_xfer *xfer, size_t xfer_hdr_size)
 				sizeof(struct wa_xfer_packet_info_hwaiso) +
 				(seg_isoc_frame_count * sizeof(__le16));
 		}
+		result = -ENOMEM;
 		seg = xfer->seg[cnt] = kmalloc(alloc_size + iso_pkt_descr_size,
 						GFP_ATOMIC);
 		if (seg == NULL)
Signature · 1 line
1.9.1