Skip to contentSkip to conversation

extcon: return error code on failure

PATCH In review Pan Bian 2 participants 3 messages Dec 3, 2016 External connector subsystem (extcon)

lore
Share & tools
lore

Pan Bian

author
#0 lore raw

PATCH 1/1 extcon: return error code on failure

Function get_zeroed_page() returns a NULL pointer if there is no enough memory. In function extcon_sync(), it returns 0 if the call to get_zeroed_page() fails. The return value 0 indicates success in the context, which is incosistent with the execution status. This patch fixes the bug by returning -ENOMEM.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188611

---
 drivers/extcon/extcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon.c +1 -1
index 7829846..7c1e3a7 100644
@@ -453,7 +453,7 @@ int extcon_sync(struct extcon_dev *edev, unsigned int id)
 		dev_err(&edev->dev, "out of memory in extcon_set_state\n");
 		kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE);
 
-		return 0;
+		return -ENOMEM;
 	}
 
 	length = name_show(&edev->dev, NULL, prop_buf);
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

Hi Pan,

2016-12-03 17:56 GMT+09:00 Pan Bian <[email protected]>:

Quoted 27 lines

Function get_zeroed_page() returns a NULL pointer if there is no enough memory. In function extcon_sync(), it returns 0 if the call to get_zeroed_page() fails. The return value 0 indicates success in the context, which is incosistent with the execution status. This patch fixes the bug by returning -ENOMEM.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188611

---
 drivers/extcon/extcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon.c +1 -2
index 7829846..7c1e3a7 100644
@@ -453,7 +453,7 @@ int extcon_sync(struct extcon_dev *edev, unsigned int id)
                dev_err(&edev->dev, "out of memory in extcon_set_state\n");
                kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE);
 
-               return 0;
+               return -ENOMEM;
        }
 
        length = name_show(&edev->dev, NULL, prop_buf);
--
Quoted 3 lines

1.9.1

Looks good to me.

Best Regards,
Chanwoo Choi

#2 lore raw

Dear Greg,

2016-12-03 21:48 GMT+09:00 Chanwoo Choi <[email protected]>:

Quoted 36 lines

Hi Pan,

2016-12-03 17:56 GMT+09:00 Pan Bian <[email protected]>:

Quoted 27 lines

Function get_zeroed_page() returns a NULL pointer if there is no enough memory. In function extcon_sync(), it returns 0 if the call to get_zeroed_page() fails. The return value 0 indicates success in the context, which is incosistent with the execution status. This patch fixes the bug by returning -ENOMEM.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188611

---
 drivers/extcon/extcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon.c +1 -2
index 7829846..7c1e3a7 100644
@@ -453,7 +453,7 @@ int extcon_sync(struct extcon_dev *edev, unsigned int id)
                dev_err(&edev->dev, "out of memory in extcon_set_state\n");
                kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE);
 
-               return 0;
+               return -ENOMEM;
        }
 
        length = name_show(&edev->dev, NULL, prop_buf);
--
Quoted 3 lines

1.9.1

Looks good to me.

Quoted 1 line

This patch fixed the issue extcon_sync's patch[1].
I think this patch should be applied on v4.9.
[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a580982f0836e079171f65f22d82768a12f85570

Could you please pick this patch on your char-msic.git treedirectly?

Signature · 2 lines
Best Regards,
Chanwoo Choi