Skip to contentSkip to conversation

Fix: Add missing pthread.h include

PATCH Applied Michael Jeanson 3 participants 3 messages Dec 5, 2016 – Jan 9, 2017 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

This should be backported to stable-2.9.

Quoted 13 lines · Michael Jeanson

Some libc like musl and uClibc requires explicit includes of pthread.h

---
 src/common/defaults.h | 1 +
 1 file changed, 1 insertion(+)
src/common/defaults.h +0 -0
index 27f1ddc..37d222a 100644

src/common/defaults.h line 26

Quoted 7 lines
src/common/defaults.h +1 -0
@@ -20,6 +20,7 @@
 #ifndef _DEFAULTS_H
 #define _DEFAULTS_H
 
+#include <pthread.h>
 #include <src/common/macros.h>
 
 /* Default unix group name for tracing. */

_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

#2 lore raw
In reply to a message not in the archive

Hello,

Quoted 3 lines · Michael Jeanson

Some libc like musl and uClibc requires explicit includes of pthread.h

This is indeed needed to fix the build on musl, I've integrated your patch in Buildroot for the time being.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
#3 lore raw
In reply to a message not in the archive

Merged, thanks!

Jérémie

Quoted 22 lines · Michael Jeanson

Some libc like musl and uClibc requires explicit includes of pthread.h

---
 src/common/defaults.h | 1 +
 1 file changed, 1 insertion(+)
src/common/defaults.h +1 -1
index 27f1ddc..37d222a 100644
@@ -20,6 +20,7 @@
 #ifndef _DEFAULTS_H
 #define _DEFAULTS_H
 
+#include <pthread.h>
 #include <src/common/macros.h>
 
 /* Default unix group name for tracing. */
--

2.7.4

Signature · 7 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev