Skip to contentSkip to conversation

drm/i915: Use DRM_DEV_ERROR in i915_driver_load

PATCH In review Tvrtko Ursulin 4 participants 5 messages Dec 6, 2016 – Dec 8, 2016

Subsystems (2)
lore
Share & tools
lore

Tvrtko Ursulin

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: Use DRM_DEV_ERROR in i915_driver_load

From: Tvrtko Ursulin <[email protected]>

Now that it is available we don't have to open code a similar error message ourselves.

---
 drivers/gpu/drm/i915/i915_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +1 -2
index 7217ecdb790d..b4bf9255a215 100644
@@ -1186,8 +1186,7 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (dev_priv)
 		ret = drm_dev_init(&dev_priv->drm, &driver, &pdev->dev);
 	if (ret) {
-		dev_printk(KERN_ERR, &pdev->dev,
-			   "[" DRM_NAME ":%s] allocation failed\n", __func__);
+		DRM_DEV_ERROR(&pdev->dev, "allocation failed\n");
 		kfree(dev_priv);
 		return ret;
 	}
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Use DRM_DEV_ERROR in i915_driver_load

== Series Details ==

== Series Details ==

Series: drm/i915: Use DRM_DEV_ERROR in i915_driver_load
URL : https://patchwork.freedesktop.org/series/16441/
State : failure

== Summary ==

Series 16441v1 drm/i915: Use DRM_DEV_ERROR in i915_driver_load
https://patchwork.freedesktop.org/api/1.0/series/16441/revisions/1/mbox/

Test drv_module_reload:

        Subgroup basic-reload-inject:
                pass       -> INCOMPLETE (fi-skl-6260u)
fi-bdw-5557u     total:247  pass:218  dwarn:0   dfail:0   fail:0   skip:29 
fi-bsw-n3050     total:247  pass:194  dwarn:0   dfail:0   fail:0   skip:53 
fi-bxt-t5700     total:247  pass:205  dwarn:0   dfail:0   fail:0   skip:42 
fi-byt-j1900     total:247  pass:205  dwarn:0   dfail:0   fail:0   skip:42 
fi-byt-n2820     total:247  pass:201  dwarn:0   dfail:0   fail:0   skip:46 
fi-hsw-4770      total:247  pass:213  dwarn:0   dfail:0   fail:0   skip:34 
fi-hsw-4770r     total:247  pass:213  dwarn:0   dfail:0   fail:0   skip:34 
fi-ilk-650       total:247  pass:180  dwarn:0   dfail:0   fail:0   skip:67 
fi-ivb-3520m     total:247  pass:212  dwarn:0   dfail:0   fail:0   skip:35 
fi-ivb-3770      total:247  pass:211  dwarn:0   dfail:0   fail:0   skip:36 
fi-kbl-7500u     total:247  pass:211  dwarn:0   dfail:0   fail:0   skip:36 
fi-skl-6260u     total:7    pass:6    dwarn:0   dfail:0   fail:0   skip:0  
fi-skl-6700hq    total:247  pass:213  dwarn:0   dfail:0   fail:0   skip:34 
fi-skl-6700k     total:247  pass:209  dwarn:3   dfail:0   fail:0   skip:35 
fi-skl-6770hq    total:247  pass:219  dwarn:0   dfail:0   fail:0   skip:28 
fi-snb-2520m     total:247  pass:201  dwarn:0   dfail:0   fail:0   skip:46 
fi-snb-2600      total:247  pass:200  dwarn:0   dfail:0   fail:0   skip:47 

08aa3ac5c18159c9105252903713cb21c27e9442 drm-tip: 2016y-12m-06d-18h-32m-52s UTC integration manifest 15c67d9 drm/i915: Use DRM_DEV_ERROR in i915_driver_load

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3209/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Tvrtko Ursulin
Quoted 6 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Now that it is available we don't have to open code a similar error message ourselves.

-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

✓ Fi.CI.BAT: success for drm/i915: Use DRM_DEV_ERROR in i915_driver_load

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: drm/i915: Use DRM_DEV_ERROR in i915_driver_load
URL : https://patchwork.freedesktop.org/series/16441/
State : success

== Summary ==

Series 16441v1 drm/i915: Use DRM_DEV_ERROR in i915_driver_load
https://patchwork.freedesktop.org/api/1.0/series/16441/revisions/1/mbox/

fi-bdw-5557u     total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14 
fi-bsw-n3050     total:247  pass:208  dwarn:0   dfail:0   fail:0   skip:39 
fi-byt-j1900     total:247  pass:220  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19 
fi-hsw-4770r     total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19 
fi-ilk-650       total:247  pass:195  dwarn:0   dfail:0   fail:0   skip:52 
fi-ivb-3520m     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-ivb-3770      total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-kbl-7500u     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6260u     total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13 
fi-skl-6700hq    total:247  pass:227  dwarn:0   dfail:0   fail:0   skip:20 
fi-skl-6700k     total:247  pass:224  dwarn:3   dfail:0   fail:0   skip:20 
fi-skl-6770hq    total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13 
fi-snb-2520m     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31 
fi-snb-2600      total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32 

17b1372b7ee9bfd08072bdbeab11b372e82c073b drm-tip: 2016y-12m-08d-10h-13m-45s UTC integration manifest 6e117d3 drm/i915: Use DRM_DEV_ERROR in i915_driver_load

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3234/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: Use DRM_DEV_ERROR in i915_driver_load

Quoted 29 lines · Patchwork

== Series Details ==

Series: drm/i915: Use DRM_DEV_ERROR in i915_driver_load
URL : https://patchwork.freedesktop.org/series/16441/
State : success

== Summary ==

Series 16441v1 drm/i915: Use DRM_DEV_ERROR in i915_driver_load
https://patchwork.freedesktop.org/api/1.0/series/16441/revisions/1/mbox/

fi-bdw-5557u     total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14
fi-bsw-n3050     total:247  pass:208  dwarn:0   dfail:0   fail:0   skip:39
fi-byt-j1900     total:247  pass:220  dwarn:0   dfail:0   fail:0   skip:27
fi-byt-n2820     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31
fi-hsw-4770      total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19
fi-hsw-4770r     total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19
fi-ilk-650       total:247  pass:195  dwarn:0   dfail:0   fail:0   skip:52
fi-ivb-3520m     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21
fi-ivb-3770      total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21
fi-kbl-7500u     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21
fi-skl-6260u     total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13
fi-skl-6700hq    total:247  pass:227  dwarn:0   dfail:0   fail:0   skip:20
fi-skl-6700k     total:247  pass:224  dwarn:3   dfail:0   fail:0   skip:20
fi-skl-6770hq    total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13
fi-snb-2520m     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31
fi-snb-2600      total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32
Quoted 2 lines

17b1372b7ee9bfd08072bdbeab11b372e82c073b drm-tip: 2016y-12m-08d-10h-13m-45s UTC integration manifest 6e117d3 drm/i915: Use DRM_DEV_ERROR in i915_driver_load

Pushed, thanks for the review!

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx