Skip to contentSkip to conversation

drm/i915: Print forcewake domain wake counts before reading register

PATCH New Sagar Arun Kamble 2 participants 2 messages Dec 15, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Print forcewake domain wake counts before reading register

Since wake count is released asynchronously, *drpc_info output indicates blitter wake count to be 1. Print these wake counts before reading registers in *drpc_info.

---
 drivers/gpu/drm/i915/i915_debugfs.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +6 -2
index 7fca6b9..3493c20 100644
@@ -1442,6 +1442,8 @@ static int vlv_drpc_info(struct seq_file *m)
 	struct drm_i915_private *dev_priv = node_to_i915(m->private);
 	u32 rpmodectl1, rcctl1, pw_status;
 
+	i915_forcewake_domains(m, NULL);
+
 	intel_runtime_pm_get(dev_priv);
 
 	pw_status = I915_READ(VLV_GTLC_PW_STATUS);
@@ -1472,7 +1474,7 @@ static int vlv_drpc_info(struct seq_file *m)
 	seq_printf(m, "Media RC6 residency since boot: %u\n",
 		   I915_READ(VLV_GT_MEDIA_RC6));
 
-	return i915_forcewake_domains(m, NULL);
+	return 0;
 }
 
 static int gen6_drpc_info(struct seq_file *m)
@@ -1484,6 +1486,8 @@ static int gen6_drpc_info(struct seq_file *m)
 	unsigned forcewake_count;
 	int count = 0, ret;
 
+	i915_forcewake_domains(m, NULL);
+
 	ret = mutex_lock_interruptible(&dev->struct_mutex);
 	if (ret)
 		return ret;
@@ -1589,7 +1593,7 @@ static int gen6_drpc_info(struct seq_file *m)
 		   GEN6_DECODE_RC6_VID(((rc6vids >> 8) & 0xff)));
 	seq_printf(m, "RC6++ voltage: %dmV\n",
 		   GEN6_DECODE_RC6_VID(((rc6vids >> 16) & 0xff)));
-	return i915_forcewake_domains(m, NULL);
+	return 0;
 }
 
 static int i915_drpc_info(struct seq_file *m, void *unused)
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915: Print forcewake domain wake counts before reading register

== Series Details ==

== Series Details ==

Series: series starting with [1/1] drm/i915: Print forcewake domain wake counts before reading register
URL : https://patchwork.freedesktop.org/series/16839/
State : success

== Summary ==

Series 16839v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/16839/revisions/1/mbox/

fi-bdw-5557u     total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14 
fi-bsw-n3050     total:247  pass:208  dwarn:0   dfail:0   fail:0   skip:39 
fi-bxt-t5700     total:247  pass:220  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-j1900     total:247  pass:220  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19 
fi-hsw-4770r     total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19 
fi-ilk-650       total:247  pass:195  dwarn:0   dfail:0   fail:0   skip:52 
fi-ivb-3520m     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-ivb-3770      total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-kbl-7500u     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6260u     total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13 
fi-skl-6700k     total:247  pass:224  dwarn:3   dfail:0   fail:0   skip:20 
fi-skl-6770hq    total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13 
fi-snb-2520m     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31 
fi-snb-2600      total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32 

fi-skl-6700hq failed to collect. IGT log at Patchwork_3293/fi-skl-6700hq/igt.log

31b6969819f8ecff09d37a4887b66f47b6fd36d3 drm-tip: 2016y-12m-15d-09h-37m-43s UTC integration manifest 3ccb4dd drm/i915: Print forcewake domain wake counts before reading register

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3293/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx