Skip to contentSkip to conversation

udoo_neo: Use 'fdtfile' variable name

PATCH New Fabio Estevam 2 participants 3 messages Dec 15, 2016 – Jan 2, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 udoo_neo: Use 'fdtfile' variable name

From: Fabio Estevam <[email protected]>

'fdtfile' is the preferred name for the variable that contains the device tree blob according to the README file.

It also makes it consistent with other i.MX boards that use config_distro, so change it accordingly.

---
 include/configs/udoo_neo.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
include/configs/udoo_neo.h +6 -6
index 81e0481..e5057be 100644
@@ -36,7 +36,7 @@
 	"console=ttymxc0,115200\0" \
 	"fdt_high=0xffffffff\0" \
 	"initrd_high=0xffffffff\0" \
-	"fdt_file=undefined\0" \
+	"fdtfile=undefined\0" \
 	"fdt_addr=0x83000000\0" \
 	"ip_dyn=yes\0" \
 	"mmcdev=0\0" \
@@ -44,14 +44,14 @@
 	"mmcautodetect=no\0" \
 	"findfdt="\
 		"if test $board_name = BASIC; then " \
-			"setenv fdt_file imx6sx-udoo-neo-basic.dtb; fi; " \
+			"setenv fdtfile imx6sx-udoo-neo-basic.dtb; fi; " \
 		"if test $board_name = BASICKS; then " \
-			"setenv fdt_file imx6sx-udoo-neo-basic.dtb; fi; " \
+			"setenv fdtfile imx6sx-udoo-neo-basic.dtb; fi; " \
 		"if test $board_name = FULL; then " \
-			"setenv fdt_file imx6sx-udoo-neo-full.dtb; fi; " \
+			"setenv fdtfile imx6sx-udoo-neo-full.dtb; fi; " \
 		"if test $board_name = EXTENDED; then " \
-			"setenv fdt_file imx6sx-udoo-neo-extended.dtb; fi; " \
-		"if test $fdt_file = UNDEFINED; then " \
+			"setenv fdtfile imx6sx-udoo-neo-extended.dtb; fi; " \
+		"if test $fdtfile = UNDEFINED; then " \
 			"echo WARNING: Could not determine dtb to use; fi; \0" \
 	"kernel_addr_r=" __stringify(CONFIG_LOADADDR) "\0" \
 	"pxefile_addr_r=" __stringify(CONFIG_LOADADDR) "\0" \
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 udoo_neo: Use 'fdtfile' variable name

Hi Tom/Stefano,

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

'fdtfile' is the preferred name for the variable that contains the device tree blob according to the README file.

It also makes it consistent with other i.MX boards that use config_distro, so change it accordingly.

Can we have this one applied for 2017.01? I would like to have the same mechanism for booting distro config as in wandbboard and cuboxi boards.

Thanks

#2 lore raw

PATCH 1/1 udoo_neo: Use 'fdtfile' variable name

In reply to Fabio Estevam
Quoted 37 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

'fdtfile' is the preferred name for the variable that contains the device tree blob according to the README file.

It also makes it consistent with other i.MX boards that use config_distro, so change it accordingly.

---
 include/configs/udoo_neo.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
include/configs/udoo_neo.h +3 -3
index 81e0481..e5057be 100644
@@ -36,7 +36,7 @@
 	"console=ttymxc0,115200\0" \
 	"fdt_high=0xffffffff\0" \
 	"initrd_high=0xffffffff\0" \
-	"fdt_file=undefined\0" \
+	"fdtfile=undefined\0" \
 	"fdt_addr=0x83000000\0" \
 	"ip_dyn=yes\0" \
 	"mmcdev=0\0" \
@@ -44,14 +44,14 @@
 	"mmcautodetect=no\0" \
 	"findfdt="\
 		"if test $board_name = BASIC; then " \
-			"setenv fdt_file imx6sx-udoo-neo-basic.dtb; fi; " \
+			"setenv fdtfile imx6sx-udoo-neo-basic.dtb; fi; " \
 		"if test $board_name = BASICKS; then " \
-			"setenv fdt_file imx6sx-udoo-neo-basic.dtb; fi; " \
+			"setenv fdtfile imx6sx-udoo-neo-basic.dtb; fi; " \
 		"if test $board_name = FULL; then " \

include/configs/udoo_neo.h line 57

Quoted 10 lines
include/configs/udoo_neo.h +3 -3
-			"setenv fdt_file imx6sx-udoo-neo-full.dtb; fi; " \
+			"setenv fdtfile imx6sx-udoo-neo-full.dtb; fi; " \
 		"if test $board_name = EXTENDED; then " \
-			"setenv fdt_file imx6sx-udoo-neo-extended.dtb; fi; " \
-		"if test $fdt_file = UNDEFINED; then " \
+			"setenv fdtfile imx6sx-udoo-neo-extended.dtb; fi; " \
+		"if test $fdtfile = UNDEFINED; then " \
 			"echo WARNING: Could not determine dtb to use; fi; \0" \
 	"kernel_addr_r=" __stringify(CONFIG_LOADADDR) "\0" \
 	"pxefile_addr_r=" __stringify(CONFIG_LOADADDR) "\0" \

Applied to u-boot-imx, -master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================