Skip to contentSkip to conversation

arm: aspeed: dts: Add I2C POWER8 OCC compatible string

PATCH In review [email protected] 2 participants 2 messages Dec 16, 2016 – Dec 20, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 6/7 arm: aspeed: dts: Add I2C POWER8 OCC compatible string

From: "Edward A. James" <[email protected]>

Add devicetree entry to probe up the POWER8 OCC driver on I2C bus.

---
 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +9 -0
index cc5fcf2..1a775f5 100644
@@ -20,6 +20,15 @@
 	};
 };
 
+&i2c3 {
+	status = "okay";
+
+	occ@50 {
+		compatible = "ibm,p8-occ-i2c";
+		reg = <0x50>;
+	};
+};
+
 &uart5 {
 	status = "okay";
 };
Signature · 1 line
1.9.1
Reviewed-by on v1 6/7
#1 lore raw
Quoted 28 lines · On Fri, 2016-12-16 at 14:36 -0600, [email protected] wrote:
Quoted 1 line

From: "Edward A. James" <[email protected]>

Add devicetree entry to probe up the POWER8 OCC driver on I2C bus.

Quoted 2 lines

---
 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 9 +++++++++

 1 file changed, 9 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +0 -0
index cc5fcf2..1a775f5 100644
@@ -20,6 +20,15 @@
 >  	};
  };


+&i2c3 {

arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts line 24

Quoted 1 line
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +1 -0
+	status = "okay";

+

Quoted 4 lines
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +4 -0
+	occ@50 {
+		compatible = "ibm,p8-occ-i2c";
+		reg = <0x50>;
+	};
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +2 -0
+};
+

 &uart5 {

Quoted 2 lines
Quoted 1 line

  status = "okay";

 };

This patch should be split out into a separate series that gets sent to the Aspeed maintainer (Joel).

However, it looks good. Given it's been completely re-written I'd drop my signed-off-by. Instead you can add:

Andrew