Skip to contentSkip to conversation

drivers: watchdog: pika_wdt: add __ro_after_init to ident

PATCH In review Bhumika Goyal 2 participants 2 messages Dec 25, 2016 – Dec 26, 2016 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: watchdog: pika_wdt: add __ro_after_init to ident

The object ident of type watchdog_info structure is not modified after getting initialized by pikawdt_init. Apart from getting referenced in init it is also passed as an argument to the function copy_to_user but this argument is of type const void *. Therefore add __ro_after_init to its declaration.

---
 drivers/watchdog/pika_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/pika_wdt.c +1 -1
index 0cdfee2..e35cf5e 100644
@@ -54,7 +54,7 @@
 	struct timer_list timer;	/* The timer that pings the watchdog */
 } pikawdt_private;
 
-static struct watchdog_info ident = {
+static struct watchdog_info ident __ro_after_init = {
 	.identity	= DRV_NAME,
 	.options	= WDIOF_CARDRESET |
 			  WDIOF_SETTIMEOUT |
Signature · 1 line
1.9.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Bhumika Goyal

The object ident of type watchdog_info structure is not modified after getting initialized by pikawdt_init. Apart from getting referenced in init it is also passed as an argument to the function copy_to_user but this argument is of type const void *. Therefore add __ro_after_init to its declaration.

Quoted 18 lines
---
 drivers/watchdog/pika_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/pika_wdt.c +1 -1
index 0cdfee2..e35cf5e 100644
@@ -54,7 +54,7 @@
 	struct timer_list timer;	/* The timer that pings the watchdog */
 } pikawdt_private;
 
-static struct watchdog_info ident = {
+static struct watchdog_info ident __ro_after_init = {
 	.identity	= DRV_NAME,
 	.options	= WDIOF_CARDRESET |
 			  WDIOF_SETTIMEOUT |