Skip to contentSkip to conversation

drm/amd/amdgpu: fix performance drop

PATCH NAK Roger.He 2 participants 2 messages Dec 28, 2016 – Jan 4, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Roger.He

author
#0 lore raw

PATCH 1/1 drm/amd/amdgpu: fix performance drop

From: "Hongbo.He" <[email protected]>

rollback to ttm default callback since OCL perf benchmark huge performance drop

Change-Id If4cfc5a52872a7e00a7cbcad6efa46c57ee533de
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2 -3
index 0f3c358..8b973be 100644
@@ -1137,9 +1137,8 @@ static struct ttm_bo_driver amdgpu_bo_driver = {
 	.fault_reserve_notify = &amdgpu_bo_fault_reserve_notify,
 	.io_mem_reserve = &amdgpu_ttm_io_mem_reserve,
 	.io_mem_free = &amdgpu_ttm_io_mem_free,
-	.lru_removal = &amdgpu_ttm_lru_removal,
-	.lru_tail = &amdgpu_ttm_lru_tail,
-	.swap_lru_tail = &amdgpu_ttm_swap_lru_tail,
+	.lru_tail = &ttm_bo_default_lru_tail,
+	.swap_lru_tail = &ttm_bo_default_swap_lru_tail,
 };
 
 int amdgpu_ttm_init(struct amdgpu_device *adev)
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1482895031-17046-1-git-send-email-Hongbo.He-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 28.12.2016 um 04:17 schrieb Roger.He:

Quoted 6 lines

From: "Hongbo.He" <[email protected]>

rollback to ttm default callback since OCL perf benchmark huge performance drop

Change-Id If4cfc5a52872a7e00a7cbcad6efa46c57ee533de

NAK, as I wrote internally as well we need this for further KFD features.

Additional to that this patch would leave unused code in the kernel driver.

I will work on properly fixing this.

Regards,
Christian.

Quoted 10 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +0 -0
index 0f3c358..8b973be 100644
@@ -1137,9 +1137,8 @@ static struct ttm_bo_driver amdgpu_bo_driver = {
  	.fault_reserve_notify = &amdgpu_bo_fault_reserve_notify,

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c static struct ttm_bo_driver amdgpu_bo_driver = { · line 1144

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2 -3
  	.io_mem_reserve = &amdgpu_ttm_io_mem_reserve,
  	.io_mem_free = &amdgpu_ttm_io_mem_free,
-	.lru_removal = &amdgpu_ttm_lru_removal,
-	.lru_tail = &amdgpu_ttm_lru_tail,
-	.swap_lru_tail = &amdgpu_ttm_swap_lru_tail,
+	.lru_tail = &ttm_bo_default_lru_tail,
+	.swap_lru_tail = &ttm_bo_default_swap_lru_tail,
  };
 
  int amdgpu_ttm_init(struct amdgpu_device *adev)

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx