Skip to contentSkip to conversation

perf/core: only check cpuctx with cgroup events during cgroup switch

PATCH New David Carrillo-Cisneros 1 participant 1 message Dec 31, 2016 perf events

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 perf/core: only check cpuctx with cgroup events during cgroup switch

v2: Fix build when no CONFIG_CGROUP_PERF

Following conversation in CQM/CMT last series about speeding up the context switch for cgroup events:

https://patchwork.kernel.org/patch/9478617/

This is a low-hanging fruit optimization. It replaces the iteration over the "pmus" list in cgroup switch by an iteration over a new list that contains only cpuctxs with at least one cgroup event.

The cost of iteration over pmus has increased with the number of pmus. It is also heavily affected by cache contention.

Below some instrumentation measurements with 10, 50 and 90 percentiles of the total cost of context switch at distinct levels of cache contenton for a simple array read/write microbenchark.

Contention
Level Nr events Before (us) After (us) Median
L2 L3 types (10%, 50%, 90%) (10%, 50%, 90% Speedup
--------------------------------------------------------------------------

Low   Low       1       (1.72, 2.42, 5.85)    (1.35, 1.64, 5.46)     29%
High  Low       1       (2.08, 4.56, 19.8)    (1720, 2.20, 13.7)     51%
High  High      1       (2.86, 10.4, 12.7)    (2.54, 4.32, 12.1)     58%
Low   Low       2       (1.98, 3.20, 6.89)    (1.68, 2.41, 8.89)     24%
High  Low       2       (2.48, 5.28, 22.4)    (2150, 3.69, 14.6)     30%
High  High      2       (3.32, 8.09, 13.9)    (2.80, 5.15, 13.7)     36%

where:
1 event type = cycles
2 event types = cycles,intel_cqm/llc_occupancy/

Contention L2 Low: workset < L2 cache size.

              High:  "    >> L2   "     " .

Contention L3 Low: workset of task on all sockets < L3 cache size.
High: " " " " " " >> L3 " " .

Median Speed up is (50%ile Before - 50%ile After) / 50%ile Before

Unsurprisingly, the benefits of this optimization decrease with the number of cpuctxs with a cgroup events, but it should never be harmful.

---
 include/linux/perf_event.h |  1 +
 kernel/events/core.c       | 98 +++++++++++++++++++++-------------------------
 2 files changed, 46 insertions(+), 53 deletions(-)
include/linux/perf_event.h +1 -0
index 4741ecd..10d2235 100644
@@ -788,6 +788,7 @@ struct perf_cpu_context {
 	struct pmu			*unique_pmu;
 #ifdef CONFIG_CGROUP_PERF
 	struct perf_cgroup		*cgrp;
+	struct list_head		cgrp_cpuctx_entry;
 #endif
 
 	struct list_head		sched_cb_entry;
kernel/events/core.c +45 -53

139 lines not on this page · raw message

Signature · 1 line
2.8.0.rc3.226.g39d4020