patch "usb: gadgetfs: restrict upper bound on device configuration size" added to usb-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
usb: gadgetfs: restrict upper bound on device configuration size
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
0994b0a257557e18ee8f0b7c5f0f73fe2b54eec1Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <[email protected]>
Date: Tue, 6 Dec 2016 08:36:29 +0100
Subject: usb: gadgetfs: restrict upper bound on device configuration size
Andrey Konovalov reported that we were not properly checking the upper limit before of a device configuration size before calling memdup_user(), which could cause some problems.
So set the upper limit to PAGE_SIZE * 4, which should be good enough for all devices.
--- drivers/usb/gadget/legacy/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/gadget/legacy/inode.c +2 -1
@@ -1762,7 +1762,8 @@ dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) }spin_unlock_irq (&dev->lock); -if (len < (USB_DT_CONFIG_SIZE +USB_DT_DEVICE_SIZE +4 )) +if ((len < (USB_DT_CONFIG_SIZE +USB_DT_DEVICE_SIZE +4 )) || + (len >PAGE_SIZE *4 ))return -EINVAL ;/* we might need to change message format someday */
Signature · 1 line
2.11.0