Skip to contentSkip to conversation

Patch "ALSA: hda - ignore the assoc and seq when comparing pin configurations" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Jan 3, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: hda - ignore the assoc and seq when comparing pin configurations

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-hda-ignore-the-assoc-and-seq-when-comparing-pin-configurations.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 64047d7f4912de1769d1bf0d34c6322494b13779 Mon Sep 17 00:00:00 2001

From: Hui Wang <[email protected]>
Date: Wed, 23 Nov 2016 16:05:37 +0800
Subject: ALSA: hda - ignore the assoc and seq when comparing pin configurations

From: Hui Wang <[email protected]>

commit 64047d7f4912de1769d1bf0d34c6322494b13779 upstream.

More and more pin configurations have been adding to the pin quirk table, lots of them are only different from assoc and seq, but they all apply to the same QUIRK_FIXUP, if we don't compare assoc and seq when matching pin configurations, it will greatly reduce the pin quirk table size.

We have tested this change on a couple of Dell laptops, it worked well.

---
 sound/pci/hda/hda_auto_parser.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/hda_auto_parser.c +1 -1
@@ -901,7 +901,7 @@ static bool pin_config_match(struct hda_
 		for (; t_pins->nid; t_pins++) {
 			if (t_pins->nid == nid) {
 				found = 1;
-				if (t_pins->val == cfg)
+				if ((t_pins->val & 0xfffffff0) == (cfg & 0xfffffff0))
 					break;
 				else if ((cfg & 0xf0000000) == 0x40000000 && (t_pins->val & 0xf0000000) == 0x40000000)
 					break;

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/alsa-hda-ignore-the-assoc-and-seq-when-comparing-pin-configurations.patch queue-4.8/alsa-hda-fix-headset-mic-problem-on-a-dell-laptop.patch