Patch "crypto: caam - fix AEAD givenc descriptors" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
crypto: caam - fix AEAD givenc descriptors
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
crypto-caam-fix-aead-givenc-descriptors.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
d128af17876d79b87edf048303f98b35f6a53dbcMon Sep 17 00:00:00 2001
From: Alex Porosanu <[email protected]>
Date: Wed, 9 Nov 2016 10:46:11 +0200
Subject: crypto: caam - fix AEAD givenc descriptors
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Alex Porosanu <[email protected]>
commit d128af17876d79b87edf048303f98b35f6a53dbc upstream.
The AEAD givenc descriptor relies on moving the IV through the output FIFO and then back to the CTX2 for authentication. The SEQ FIFO STORE could be scheduled before the data can be read from OFIFO, especially since the SEQ FIFO LOAD needs to wait for the SEQ FIFO LOAD SKIP to finish first. The SKIP takes more time when the input is SG than when it's a contiguous buffer. If the SEQ FIFO LOAD is not scheduled before the STORE, the DECO will hang waiting for data to be available in the OFIFO so it can be transferred to C2. In order to overcome this, first force transfer of IV to C2 by starting the "cryptlen" transfer first and then starting to store data from OFIFO to the output buffer.
--- drivers/crypto/caam/caamalg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/crypto/caam/caamalg.c +3 -1
@@ -702,7 +702,9 @@ copy_iv:/* Will read cryptlen */ append_math_add (desc,VARSEQINLEN ,SEQINLEN ,REG0 ,CAAM_CMD_SZ ); -aead_append_src_dst (desc,FIFOLD_TYPE_MSG1OUT2 ); +append_seq_fifo_load (desc,0 ,FIFOLD_CLASS_BOTH |KEY_VLF | +FIFOLD_TYPE_MSG1OUT2 |FIFOLD_TYPE_LASTBOTH ); +append_seq_fifo_store (desc,0 ,FIFOST_TYPE_MESSAGE_DATA |KEY_VLF );/* Write ICV */ append_seq_store(desc, ctx->authsize, LDST_CLASS_2_CCB |
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/crypto-caam-fix-aead-givenc-descriptors.patch