Skip to contentSkip to conversation

Patch "xfs: set AGI buffer type in xlog_recover_clear_agi_bucket" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Jan 4, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

xfs: set AGI buffer type in xlog_recover_clear_agi_bucket

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
xfs-set-agi-buffer-type-in-xlog_recover_clear_agi_bucket.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6b10b23ca94451fae153a5cc8d62fd721bec2019 Mon Sep 17 00:00:00 2001

From: Eric Sandeen <[email protected]>
Date: Mon, 5 Dec 2016 12:31:06 +1100
Subject: xfs: set AGI buffer type in xlog_recover_clear_agi_bucket

From: Eric Sandeen <[email protected]>

commit 6b10b23ca94451fae153a5cc8d62fd721bec2019 upstream.

xlog_recover_clear_agi_bucket didn't set the type to XFS_BLFT_AGI_BUF, so we got a warning during log replay (or an ASSERT on a debug build).

XFS (md0): Unknown buffer type 0!
XFS (md0): _xfs_buf_ioapply: no ops on block 0xaea8802/0x1

Fix this, as was done in f19b872b for 2 other locations with the same problem.

---
 fs/xfs/xfs_log_recover.c |    1 +
 1 file changed, 1 insertion(+)
fs/xfs/xfs_log_recover.c +1 -0
@@ -4506,6 +4506,7 @@ xlog_recover_clear_agi_bucket(
 	agi->agi_unlinked[bucket] = cpu_to_be32(NULLAGINO);
 	offset = offsetof(xfs_agi_t, agi_unlinked) +
 		 (sizeof(xfs_agino_t) * bucket);
+	xfs_trans_buf_set_type(tp, agibp, XFS_BLFT_AGI_BUF);
 	xfs_trans_log_buf(tp, agibp, offset,
 			  (offset + sizeof(xfs_agino_t) - 1));
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/xfs-set-agi-buffer-type-in-xlog_recover_clear_agi_bucket.patch