patch "USB: serial: io_edgeport: fix NULL-deref at open" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: io_edgeport: fix NULL-deref at open
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
0dd408425eb21ddf26a692b3c8044c9e7d1a7948Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Tue, 3 Jan 2017 16:39:42 +0100
Subject: USB: serial: io_edgeport: fix NULL-deref at open
Fix NULL-pointer dereference when initialising URBs at open should a non-EPIC device lack a bulk-in or interrupt-in endpoint.
Unable to handle kernel NULL pointer dereference at virtual address 00000028
...
PC is at edge_open+0x24c/0x3e8 [io_edgeport]
Note that the EPIC-device probe path has the required sanity checks so this makes those checks partially redundant.
--- drivers/usb/serial/io_edgeport.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/usb/serial/io_edgeport.c +5 -0
@@ -2751,6 +2751,11 @@ static int edge_startup(struct usb_serial *serial)EDGE_COMPATIBILITY_MASK1 , EDGE_COMPATIBILITY_MASK2 }; +if (serial->num_bulk_in <1 || serial->num_interrupt_in <1 ) { +dev_err (&serial->interface->dev,"missing endpoints\n" ); +return -ENODEV ; + } + dev = serial->dev;/* create our private serial structure */
Signature · 1 line
2.11.0