patch "USB: serial: quatech2: fix sleep-while-atomic in close" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: quatech2: fix sleep-while-atomic in close
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
f09d1886a41e9063b43da493ef0e845ac8afd2faMon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Tue, 3 Jan 2017 16:40:01 +0100
Subject: USB: serial: quatech2: fix sleep-while-atomic in close
The write URB was being killed using the synchronous interface while holding a spin lock in close().
Simply drop the lock and busy-flag update, something which would have been taken care of by the completion handler if the URB was in flight.
--- drivers/usb/serial/quatech2.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/usb/serial/quatech2.c +0 -4
@@ -408,16 +408,12 @@ static void qt2_close(struct usb_serial_port *port) {struct usb_serial *serial;struct qt2_port_private *port_priv; -unsigned long flags;int i; serial = port->serial; port_priv =usb_get_serial_port_data (port); -spin_lock_irqsave (&port_priv->urb_lock, flags);usb_kill_urb (port_priv->write_urb); - port_priv->urb_in_use = false; -spin_unlock_irqrestore (&port_priv->urb_lock, flags);/* flush the port transmit buffer */ i = usb_control_msg(serial->dev,
Signature · 1 line
2.11.0