Patch "gpio: stmpe: fix interrupt handling bug" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
gpio: stmpe: fix interrupt handling bug
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
gpio-stmpe-fix-interrupt-handling-bug.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
1516c6350aa2770b8a5e36d40c3ec5078f92ba70Mon Sep 17 00:00:00 2001
From: Linus Walleij <[email protected]>
Date: Wed, 23 Nov 2016 23:21:17 +0100
Subject: gpio: stmpe: fix interrupt handling bug
From: Linus Walleij <[email protected]>
commit 1516c6350aa2770b8a5e36d40c3ec5078f92ba70 upstream.
commit 43db289d00c6 ("gpio: stmpe: Rework registers access") reworked the STMPE register access so as to use [STMPE_IDX_*_LSB + i] to access the 8bit register for a certain bank, assuming the CSB and MSB will follow after the enumerator. For this to work the index needs to go from (size-1) to 0 not 0 to (size-1).
However for the GPIO IRQ handler, the status registers we read register MSB + 3 bytes ahead for the 24 bit GPIOs and index registers from MSB upwards and run an index i over the registers UNLESS we are STMPE1600.
This is not working when we get to clearing the interrupt EDGE status register STMPE_IDX_GPEDR_[LCM]SB: it is indexed like all other registers [STMPE_IDX_*_LSB + i] but in this loop we index from 0 to get the right bank index for the calculations, and we need to just add i to the MSB.
Before this, interrupts on the STMPE2401 were broken, this patch fixes it so it works again.
--- drivers/gpio/gpio-stmpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-stmpe.c +1 -1
@@ -413,7 +413,7 @@ static irqreturn_t stmpe_gpio_irq(int ir stmpe->partnum != STMPE1801) {stmpe_reg_write (stmpe, statmsbreg + i, status[i]);stmpe_reg_write (stmpe, - stmpe->regs[STMPE_IDX_GPEDR_LSB + i], + stmpe->regs[STMPE_IDX_GPEDR_MSB ] + i, status[i]); } }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/gpio-chardev-return-error-for-seek-operations.patch queue-4.9/gpio-stmpe-fix-interrupt-handling-bug.patch queue-4.9/regulator-stw481x-vmmc-fix-ages-old-enable-error.patch