Skip to contentSkip to conversation

Patch "drm/nouveau/bios: require checksum to match for fast acpi shadow method" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Jan 6, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/nouveau/bios: require checksum to match for fast acpi shadow method

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-nouveau-bios-require-checksum-to-match-for-fast-acpi-shadow-method.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5dc7f4aa9d84ea94b54a9bfcef095f0289f1ebda Mon Sep 17 00:00:00 2001

From: Ben Skeggs <[email protected]>
Date: Fri, 14 Oct 2016 13:16:36 +1000
Subject: drm/nouveau/bios: require checksum to match for fast acpi shadow method

From: Ben Skeggs <[email protected]>

commit 5dc7f4aa9d84ea94b54a9bfcef095f0289f1ebda upstream.

---
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/priv.h       |    1 +
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c     |    7 +++++--
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowacpi.c |    1 +
 3 files changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/nouveau/nvkm/subdev/bios/priv.h +1 -0
@@ -12,6 +12,7 @@ struct nvbios_source {
 	bool rw;
 	bool ignore_checksum;
 	bool no_pcir;
+	bool require_checksum;
 };
 
 int nvbios_extend(struct nvkm_bios *, u32 length);
drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c +5 -2
@@ -86,9 +86,12 @@ shadow_image(struct nvkm_bios *bios, int
 		    nvbios_checksum(&bios->data[image.base], image.size)) {
 			nvkm_debug(subdev, "%08x: checksum failed\n",
 				   image.base);
-			if (mthd->func->rw)
+			if (!mthd->func->require_checksum) {
+				if (mthd->func->rw)
+					score += 1;
 				score += 1;
-			score += 1;
+			} else
+				return 0;
 		} else {
 			score += 3;
 		}
drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowacpi.c +1 -0
@@ -99,6 +99,7 @@ nvbios_acpi_fast = {
 	.init = acpi_init,
 	.read = acpi_read_fast,
 	.rw = false,
+	.require_checksum = true,
 };
 
 const struct nvbios_source

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/drm-nouveau-ttm-wait-for-bo-fence-to-signal-before-unmapping-vmas.patch queue-4.8/drm-nouveau-bios-require-checksum-to-match-for-fast-acpi-shadow-method.patch queue-4.8/drm-nouveau-gr-fallback-to-legacy-paths-during-firmware-lookup.patch queue-4.8/drm-nouveau-kms-lvds-panel-strap-moved-again-on-maxwell.patch queue-4.8/drm-nouveau-ltc-protect-clearing-of-comptags-with-mutex.patch queue-4.8/drm-nouveau-fifo-gf100-protect-channel-preempt-with-subdev-mutex.patch queue-4.8/drm-nouveau-i2c-gk110b-gm10x-use-the-correct-implementation.patch