Skip to contentSkip to conversation

Patch "IPoIB: Avoid reading an uninitialized member variable" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jan 6, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

IPoIB: Avoid reading an uninitialized member variable

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ipoib-avoid-reading-an-uninitialized-member-variable.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 11b642b84e8c43e8597de031678d15c08dd057bc Mon Sep 17 00:00:00 2001

From: Bart Van Assche <[email protected]>
Date: Mon, 21 Nov 2016 10:21:41 -0800
Subject: IPoIB: Avoid reading an uninitialized member variable

From: Bart Van Assche <[email protected]>

commit 11b642b84e8c43e8597de031678d15c08dd057bc upstream.

This patch avoids that Coverity reports the following:

Using uninitialized value port_attr.state when calling printk

Fixes commit 94232d9ce817 ("IPoIB: Start multicast join process only on active ports")
Cc Erez Shitrit <[email protected]>
---
 drivers/infiniband/ulp/ipoib/ipoib_multicast.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_multicast.c +5 -2
@@ -563,8 +563,11 @@ void ipoib_mcast_join_task(struct work_s
 	if (!test_bit(IPOIB_FLAG_OPER_UP, &priv->flags))
 		return;
 
-	if (ib_query_port(priv->ca, priv->port, &port_attr) ||
-	    port_attr.state != IB_PORT_ACTIVE) {
+	if (ib_query_port(priv->ca, priv->port, &port_attr)) {
+		ipoib_dbg(priv, "ib_query_port() failed\n");
+		return;
+	}
+	if (port_attr.state != IB_PORT_ACTIVE) {
 		ipoib_dbg(priv, "port state is not ACTIVE (state = %d) suspending join task\n",
 			  port_attr.state);
 		return;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ib-mad-fix-an-array-index-check.patch queue-4.4/ipoib-avoid-reading-an-uninitialized-member-variable.patch queue-4.4/ib-multicast-check-ib_find_pkey-return-value.patch queue-4.4/ib-cma-fix-a-race-condition-in-iboe_addr_get_sgid.patch