drm/amdgpu: remove detect_hw_virtualization interface
Subsystems (2)
PATCH 2/2 drm/amdgpu: remove detect_hw_virtualization interface
Don't use the interface anymore, remove it.
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 -- drivers/gpu/drm/amd/amdgpu/cik.c | 7 ------- drivers/gpu/drm/amd/amdgpu/si.c | 7 ------- 3 files changed, 16 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +0 -2
@@ -1192,7 +1192,6 @@ struct amdgpu_asic_funcs {bool (*read_disabled_bios)(struct amdgpu_device *adev);bool (*read_bios_from_rom)(struct amdgpu_device *adev,u8 *bios,u32 length_bytes); -void (*detect_hw_virtualization) (struct amdgpu_device *adev);int (*read_register)(struct amdgpu_device *adev,u32 se_num,u32 sh_num,u32 reg_offset,u32 *value);void (*set_vga_state)(struct amdgpu_device *adev,bool state);
@@ -1626,7 +1625,6 @@ amdgpu_get_sdma_instance(struct amdgpu_ring *ring)#define amdgpu_asic_get_gpu_clock_counter (adev) (adev)->asic_funcs->get_gpu_clock_counter((adev))#define amdgpu_asic_read_disabled_bios (adev) (adev)->asic_funcs->read_disabled_bios((adev))#define amdgpu_asic_read_bios_from_rom (adev, b, l) (adev)->asic_funcs->read_bios_from_rom((adev), (b), (l)) -#define amdgpu_asic_detect_hw_virtualization (adev) (adev)->asic_funcs->detect_hw_virtualization((adev))#define amdgpu_asic_read_register (adev, se, sh, offset, v)((adev)->asic_funcs->read_register((adev), (se), (sh), (offset), (v)))#define amdgpu_gart_flush_gpu_tlb (adev, vmid) (adev)->gart.gart_funcs->flush_gpu_tlb((adev), (vmid))#define amdgpu_gart_set_pte_pde (adev, pt, idx, addr, flags) (adev)->gart.gart_funcs->set_pte_pde((adev), (pt), (idx), (addr), (flags))
drivers/gpu/drm/amd/amdgpu/cik.c +0 -7
@@ -1625,17 +1625,10 @@ static uint32_t cik_get_rev_id(struct amdgpu_device *adev) >> CC_DRM_ID_STRAPS__ATI_REV_ID__SHIFT; } -static void cik_detect_hw_virtualization (struct amdgpu_device *adev) -{ -if (is_virtual_machine ())/* passthrough mode */ - adev->virt.caps |=AMDGPU_PASSTHROUGH_MODE ; -} -static const struct amdgpu_asic_funcs cik_asic_funcs = { .read_disabled_bios = &cik_read_disabled_bios, .read_bios_from_rom = &cik_read_bios_from_rom, - .detect_hw_virtualization = cik_detect_hw_virtualization, .read_register = &cik_read_register, .reset = &cik_asic_reset, .set_vga_state = &cik_vga_set_state,
drivers/gpu/drm/amd/amdgpu/si.c +0 -7
@@ -1135,16 +1135,9 @@ static int si_set_uvd_clocks(struct amdgpu_device *adev, u32 vclk, u32 dclk)return 0 ; } -static void si_detect_hw_virtualization (struct amdgpu_device *adev) -{ -if (is_virtual_machine ())/* passthrough mode */ - adev->virt.caps |=AMDGPU_PASSTHROUGH_MODE ; -} -static const struct amdgpu_asic_funcs si_asic_funcs = { .read_disabled_bios = &si_read_disabled_bios, - .detect_hw_virtualization = si_detect_hw_virtualization, .read_register = &si_read_register, .reset = &si_asic_reset, .set_vga_state = &si_vga_set_state,
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1483845169-13445-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org
after you removed this interface, don't forget to call thos "xx_detect_hw_virtualization" in head of xx_set_ip_blocks() routine
e.g. CI also need its "adev->virt.caps" with flag of "AMDGPU_PASSTHROUGH_MODE"
BR Monk
________________________________
发件人: amd-gfx <[email protected]> 代表 Xiangliang Yu <[email protected]> 发送时间: 2017年1月8日 11:12:49
收件人: [email protected]
抄送: Yu, Xiangliang
主题: [PATCH 2/2] drm/amdgpu: remove detect_hw_virtualization interface
Don't use the interface anymore, remove it.
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 -- drivers/gpu/drm/amd/amdgpu/cik.c | 7 ------- drivers/gpu/drm/amd/amdgpu/si.c | 7 ------- 3 files changed, 16 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +0 -2
@@ -1192,7 +1192,6 @@ struct amdgpu_asic_funcs {bool (*read_disabled_bios)(struct amdgpu_device *adev);bool (*read_bios_from_rom)(struct amdgpu_device *adev,u8 *bios,u32 length_bytes); -void (*detect_hw_virtualization) (struct amdgpu_device *adev);int (*read_register)(struct amdgpu_device *adev,u32 se_num,u32 sh_num,u32 reg_offset,u32 *value);void (*set_vga_state)(struct amdgpu_device *adev,bool state);
@@ -1626,7 +1625,6 @@ amdgpu_get_sdma_instance(struct amdgpu_ring *ring)#define amdgpu_asic_get_gpu_clock_counter (adev) (adev)->asic_funcs->get_gpu_clock_counter((adev))#define amdgpu_asic_read_disabled_bios (adev) (adev)->asic_funcs->read_disabled_bios((adev))#define amdgpu_asic_read_bios_from_rom (adev, b, l) (adev)->asic_funcs->read_bios_from_rom((adev), (b), (l)) -#define amdgpu_asic_detect_hw_virtualization (adev) (adev)->asic_funcs->detect_hw_virtualization((adev))#define amdgpu_asic_read_register (adev, se, sh, offset, v)((adev)->asic_funcs->read_register((adev), (se), (sh), (offset), (v)))#define amdgpu_gart_flush_gpu_tlb (adev, vmid) (adev)->gart.gart_funcs->flush_gpu_tlb((adev), (vmid))#define amdgpu_gart_set_pte_pde (adev, pt, idx, addr, flags) (adev)->gart.gart_funcs->set_pte_pde((adev), (pt), (idx), (addr), (flags))
drivers/gpu/drm/amd/amdgpu/cik.c +0 -7
@@ -1625,17 +1625,10 @@ static uint32_t cik_get_rev_id(struct amdgpu_device *adev) >> CC_DRM_ID_STRAPS__ATI_REV_ID__SHIFT; } -static void cik_detect_hw_virtualization (struct amdgpu_device *adev) -{ -if (is_virtual_machine ())/* passthrough mode */ - adev->virt.caps |=AMDGPU_PASSTHROUGH_MODE ; -} -static const struct amdgpu_asic_funcs cik_asic_funcs = { .read_disabled_bios = &cik_read_disabled_bios, .read_bios_from_rom = &cik_read_bios_from_rom, - .detect_hw_virtualization = cik_detect_hw_virtualization, .read_register = &cik_read_register, .reset = &cik_asic_reset, .set_vga_state = &cik_vga_set_state,
drivers/gpu/drm/amd/amdgpu/si.c +0 -7
@@ -1135,16 +1135,9 @@ static int si_set_uvd_clocks(struct amdgpu_device *adev, u32 vclk, u32 dclk)return 0 ; } -static void si_detect_hw_virtualization (struct amdgpu_device *adev) -{ -if (is_virtual_machine ())/* passthrough mode */ - adev->virt.caps |=AMDGPU_PASSTHROUGH_MODE ; -} -static const struct amdgpu_asic_funcs si_asic_funcs = { .read_disabled_bios = &si_read_disabled_bios, - .detect_hw_virtualization = si_detect_hw_virtualization, .read_register = &si_read_register, .reset = &si_asic_reset, .set_vga_state = &si_vga_set_state,
--
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): BY2PR1201MB1110912AAE15127F5BE9F38B84640-O28G1zQ8oGliQkyLPkmea2rFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/[email protected]
Quoted 9 lines
From: Liu, Monk
Sent: Monday, January 09, 2017 11:32 AM
To: Yu, Xiangliang <[email protected]>; [email protected]
Subject: 答复: [PATCH 2/2] drm/amdgpu: removedetect_hw_virtualizationinterfaceafter you removed this interface, don't forget to call thos "
xx_detect_hw_virtualization" in head ofxx_set_ip_blocks()routinee.g. CI also need its "
adev->virt.caps" with flag of "AMDGPU_PASSTHROUGH_MODE"
Sure.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx