Patch "iio: common: st_sensors: fix channel data parsing" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iio: common: st_sensors: fix channel data parsing
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iio-common-st_sensors-fix-channel-data-parsing.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
65c8aea07de11b6507efa175edb44bd8b4488218Mon Sep 17 00:00:00 2001
From: Lorenzo Bianconi <[email protected]>
Date: Wed, 16 Nov 2016 22:15:28 +0100
Subject: iio: common: st_sensors: fix channel data parsing
From: Lorenzo Bianconi <[email protected]>
commit 65c8aea07de11b6507efa175edb44bd8b4488218 upstream.
Using realbits as i2c/spi read len, when that value is not byte aligned (e.g 12 bits), lead to skip msb part of out data registers. Fix this taking into account scan_type.shift in addition to scan_type.realbits as read length:
read_len = DIV_ROUND_UP(realbits + shift, 8)
This fix has been tested on 8, 12, 16, 24 bit sensors
--- drivers/iio/common/st_sensors/st_sensors_buffer.c | 4 +++- drivers/iio/common/st_sensors/st_sensors_core.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
drivers/iio/common/st_sensors/st_sensors_buffer.c +3 -1
@@ -30,7 +30,9 @@ static int st_sensors_get_buffer_elementfor_each_set_bit (i, indio_dev->active_scan_mask, num_data_channels) {const struct iio_chan_spec *channel = &indio_dev->channels[i]; -unsigned int bytes_to_read = channel->scan_type.realbits >>3 ; +unsigned int bytes_to_read = +DIV_ROUND_UP (channel->scan_type.realbits + + channel->scan_type.shift,8 );unsigned int storage_bytes = channel->scan_type.storagebits >>3 ;
drivers/iio/common/st_sensors/st_sensors_core.c +3 -1
@@ -483,8 +483,10 @@ static int st_sensors_read_axis_data(strint err;u8 *outdata;struct st_sensor_data *sdata =iio_priv (indio_dev); -unsigned int byte_for_channel = ch->scan_type.realbits >>3 ; +unsigned int byte_for_channel; + byte_for_channel =DIV_ROUND_UP (ch->scan_type.realbits + + ch->scan_type.shift,8 ); outdata =kmalloc (byte_for_channel,GFP_KERNEL );if (!outdata)return -ENOMEM ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/iio-common-st_sensors-fix-channel-data-parsing.patch