Patch "usb: return error code when platform_get_irq fails" has been added to the 4.9-stable tree
Subsystems (5)
This is a note to let you know that I've just added the patch titled
usb: return error code when platform_get_irq fails
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-return-error-code-when-platform_get_irq-fails.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
28bedb5ae463b9f7e5195cbc93f1795e374bdef8Mon Sep 17 00:00:00 2001
From: Pan Bian <[email protected]>
Date: Tue, 3 Jan 2017 18:28:45 +0200
Subject: usb: return error code when platform_get_irq fails
From: Pan Bian <[email protected]>
commit 28bedb5ae463b9f7e5195cbc93f1795e374bdef8 upstream.
In function xhci_mtk_probe(), variable ret takes the return value. Its value should be negative on failures. However, when the call to function platform_get_irq() fails, it does not set the error code, and 0 will be returned. 0 indicates no error. As a result, the callers of function xhci_mtk_probe() will not be able to detect the error. This patch fixes the bug by assigning the return value of platform_get_irq() to variable ret if it fails.
--- drivers/usb/host/xhci-mtk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/host/xhci-mtk.c +3 -1
@@ -560,8 +560,10 @@ static int xhci_mtk_probe(struct platfor goto disable_ldos; irq =platform_get_irq (pdev,0 ); -if (irq <0 ) +if (irq <0 ) { + ret = irq; goto disable_clk; + }/* Initialize dma_mask and coherent_dma_mask to 32-bits */ ret =dma_set_coherent_mask (dev,DMA_BIT_MASK (32 ));
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/usb-return-error-code-when-platform_get_irq-fails.patch