Skip to contentSkip to conversation

Patch "clk: clk-wm831x: fix a logic error" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jan 9, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

clk: clk-wm831x: fix a logic error

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     clk-clk-wm831x-fix-a-logic-error.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 20979202ee6e4c68dab7bcf408787225a656d18e Mon Sep 17 00:00:00 2001

From: Pan Bian <[email protected]>
Date: Thu, 1 Dec 2016 14:25:44 +0800
Subject: clk: clk-wm831x: fix a logic error

From: Pan Bian <[email protected]>

commit 20979202ee6e4c68dab7bcf408787225a656d18e upstream.

Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function wm831x_clkout_is_prepared() returns "true" when it fails to read CLOCK_CONTROL_1. "true" means the device is already prepared. So return "true" on the read failure seems improper.

Fixes f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver")
---
 drivers/clk/clk-wm831x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-wm831x.c +1 -1
@@ -247,7 +247,7 @@ static int wm831x_clkout_is_prepared(str
 	if (ret < 0) {
 		dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n",
 			ret);
-		return true;
+		return false;
 	}
 
 	return (ret & WM831X_CLKOUT_ENA) != 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/usb-serial-kl5kusb105-abort-on-open-exception-path.patch queue-4.4/clk-clk-wm831x-fix-a-logic-error.patch