Skip to contentSkip to conversation

x86/cpuid: Add AVX512_VPOPCNTDQ support

PATCH Superseded He Chen 2 participants 3 messages Jan 10, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

He Chen

author
#0 lore raw

PATCH 1/1 x86/cpuid: Add AVX512_VPOPCNTDQ support

AVX512_VPOPCNTDQ: Vector POPCNT instructions for word and qwords. variable precision.

---
 xen/include/public/arch-x86/cpufeatureset.h | 1 +
 xen/tools/gen-cpuid.py                      | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
xen/include/public/arch-x86/cpufeatureset.h +1 -0
index 565ccd5..285224d 100644
@@ -226,6 +226,7 @@ XEN_CPUFEATURE(PREFETCHWT1,   6*32+ 0) /*A  PREFETCHWT1 instruction */
 XEN_CPUFEATURE(AVX512VBMI,    6*32+ 1) /*A  AVX-512 Vector Byte Manipulation Instrs */
 XEN_CPUFEATURE(PKU,           6*32+ 3) /*H  Protection Keys for Userspace */
 XEN_CPUFEATURE(OSPKE,         6*32+ 4) /*!  OS Protection Keys Enable */
+XEN_CPUFEATURE(VPOPCNTDQ,     6*32+14) /*A  POPCNT for vectors of DW/QW */
 
 /* AMD-defined CPU features, CPUID level 0x80000007.edx, word 7 */
 XEN_CPUFEATURE(ITSC,          7*32+ 8) /*   Invariant TSC */
xen/tools/gen-cpuid.py +2 -1
index 420a5cc..1067c85 100755
@@ -255,7 +255,8 @@ def crunch_numbers(state):
         # 512bit registers, and the instructions themselves. All further AVX512 features
         # are built on top of AVX512F
         AVX512F: [AVX512DQ, AVX512IFMA, AVX512PF, AVX512ER, AVX512CD,
-                  AVX512BW, AVX512VL, AVX512VBMI, AVX512_4VNNIW, AVX512_4FMAPS],
+                  AVX512BW, AVX512VL, AVX512VBMI, AVX512_4VNNIW,
+                  AVX512_4FMAPS, VPOPCNTDQ],
     }
 
     deep_features = tuple(sorted(deps.keys()))
Signature · 7 lines
2.7.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
#1 lore raw

xen/include/public/arch-x86/cpufeatureset.h XEN_CPUFEATURE(PREFETCHWT1, 6*32+ 0) /*A PREFETCHWT1 instruction */ · line 229

Quoted 8 lines
Quoted 1 line
Quoted 1 line · On 10.01.17 at 07:34, <[email protected]> wrote:
xen/include/public/arch-x86/cpufeatureset.h +1 -0
@@ -226,6 +226,7 @@ XEN_CPUFEATURE(PREFETCHWT1,   6*32+ 0) /*A  PREFETCHWT1 instruction */
 XEN_CPUFEATURE(AVX512VBMI,    6*32+ 1) /*A  AVX-512 Vector Byte Manipulation Instrs */
 XEN_CPUFEATURE(PKU,           6*32+ 3) /*H  Protection Keys for Userspace */
 XEN_CPUFEATURE(OSPKE,         6*32+ 4) /*!  OS Protection Keys Enable */
+XEN_CPUFEATURE(VPOPCNTDQ,     6*32+14) /*A  POPCNT for vectors of DW/QW */

Hmm, the document has an AVX512_ prefix here, and while that's a little lengthy I think we should try to stick to SDM names.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel

author
#2 lore raw
Quoted 12 lines · Jan Beulich

xen/include/public/arch-x86/cpufeatureset.h XEN_CPUFEATURE(PREFETCHWT1, 6*32+ 0) /*A PREFETCHWT1 instruction */ · line 229

Quoted 8 lines
Quoted 1 line
Quoted 1 line · On 10.01.17 at 07:34, <[email protected]> wrote:
xen/include/public/arch-x86/cpufeatureset.h +1 -0
@@ -226,6 +226,7 @@ XEN_CPUFEATURE(PREFETCHWT1,   6*32+ 0) /*A  PREFETCHWT1 instruction */
 XEN_CPUFEATURE(AVX512VBMI,    6*32+ 1) /*A  AVX-512 Vector Byte Manipulation Instrs */
 XEN_CPUFEATURE(PKU,           6*32+ 3) /*H  Protection Keys for Userspace */
 XEN_CPUFEATURE(OSPKE,         6*32+ 4) /*!  OS Protection Keys Enable */
+XEN_CPUFEATURE(VPOPCNTDQ,     6*32+14) /*A  POPCNT for vectors of DW/QW */

Hmm, the document has an AVX512_ prefix here, and while that's a little lengthy I think we should try to stick to SDM names.

Sure.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel