vme: Fix wrong pointer utilization in ca91cx42_slave_get
PATCH 1/1 vme: Fix wrong pointer utilization in ca91cx42_slave_get
In ca91cx42_slave_get function, the value pointed by vme_base pointer is set through:
*vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]);
So it must be dereferenced to be used in calculation of pci_base:
*pci_base = (dma_addr_t)*vme_base + pci_offset;
This bug was caught thanks to the following gcc warning:
drivers/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_slave_get’:drivers/vme/bridges/vme_ca91cx42.c:467:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]*pci_base = (dma_addr_t)vme_base + pci_offset;
--- drivers/vme/bridges/vme_ca91cx42.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vme/bridges/vme_ca91cx42.c +1 -1
@@ -464,7 +464,7 @@ static int ca91cx42_slave_get(struct vme_slave_resource *image, int *enabled, vme_bound =ioread32 (bridge->base +CA91CX42_VSI_BD [i]); pci_offset =ioread32 (bridge->base +CA91CX42_VSI_TO [i]); - *pci_base = (dma_addr_t )vme_base + pci_offset; + *pci_base = (dma_addr_t)*vme_base + pci_offset; *size = (unsigned long long )((vme_bound - *vme_base) + granularity); *enabled =0 ;
Signature · 1 line
2.7.4
Quoted 9 lines · Augusto Mecking Caringi
In
ca91cx42_slave_getfunction, the value pointed byvme_basepointer is set through:
*vme_base=ioread32(bridge->base + CA91CX42_VSI_BS[i]);So it must be dereferenced to be used in calculation of
pci_base:
*pci_base= (dma_addr_t)*vme_base +pci_offset;
Quoted 8 lines
This bug was caught thanks to the following gcc warning:
drivers/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_slave_get’:drivers/vme/bridges/vme_ca91cx42.c:467:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]*pci_base= (dma_addr_t)vme_base +pci_offset;Signed-off-by Augusto Mecking Caringi <[email protected]>
Quoted 20 lines
--- drivers/vme/bridges/vme_ca91cx42.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vme/bridges/vme_ca91cx42.c +1
-2@@ -464,7 +464,7 @@ static int ca91cx42_slave_get(struct vme_slave_resource *image, int *enabled, vme_bound =ioread32 (bridge->base +CA91CX42_VSI_BD [i]); pci_offset =ioread32 (bridge->base +CA91CX42_VSI_TO [i]); - *pci_base = (dma_addr_t )vme_base + pci_offset; + *pci_base = (dma_addr_t)*vme_base + pci_offset; *size = (unsigned long long )((vme_bound - *vme_base) + granularity); *enabled =0 ; --2.7.4