Skip to contentSkip to conversation

amdgpu: Provide more specific error message if non-privileged user runs amdgpu_test

PATCH In review Alex Xie 3 participants 3 messages Jan 12, 2017 – Jan 13, 2017 2 messages not in the archive

lore
Share & tools
lore

Alex Xie

author
#0 lore raw

PATCH 1/1 amdgpu: Provide more specific error message if non-privileged user runs amdgpu_test

Before this change, the error message is:
"WARNING - Suite initialization failed..."
People might think this is a driver problem.

Tested with non-privileged user. Now the error message is like:
...
Error:Permission denied. Hint:Try to run this test program as root. WARNING - Suite initialization failed for 'Basic Tests'.
...

Tested as root with no regression.

amdgpu_test uses CUnit. CUnit outputs warning message to stdout. To be consistent, this commit outputs error message to stdout.

v2: Use strerror instead of %m. %m is a GNU C Library extension.
v3: Limit code and commit message within 80 characters per line.
Update commit message.
Remove a space before starting parenthesis in function call.

Change-Id Ib891c40ec812053f49ce5a99909455ac3137e32c
---
 tests/amdgpu/basic_tests.c | 7 ++++++-
 tests/amdgpu/bo_tests.c    | 8 +++++++-
 tests/amdgpu/cs_tests.c    | 8 +++++++-
 tests/amdgpu/vce_tests.c   | 8 +++++++-
 4 files changed, 27 insertions(+), 4 deletions(-)
tests/amdgpu/basic_tests.c +6 -1
index 11f6a63..bfda21b 100644
@@ -206,8 +206,13 @@ int suite_basic_tests_init(void)
 
 	if (r == 0)
 		return CUE_SUCCESS;
-	else
+	else {
+		if ((r == -EACCES) && (errno == EACCES))
+			printf("\n\nError:%s. "
+				"Hint:Try to run this test program as root.",
+				strerror(errno));
 		return CUE_SINIT_FAILED;
+	}
 }
 
 int suite_basic_tests_clean(void)
tests/amdgpu/bo_tests.c +7 -1
index 993895d..25df767 100644
@@ -65,8 +65,14 @@ int suite_bo_tests_init(void)
 
 	r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
 				  &minor_version, &device_handle);
-	if (r)
+	if (r) {
+		if ((r == -EACCES) && (errno == EACCES))
+			printf("\n\nError:%s. "
+				"Hint:Try to run this test program as root.",
+				strerror(errno));
+
 		return CUE_SINIT_FAILED;
+	}
 
 	req.alloc_size = BUFFER_SIZE;
 	req.phys_alignment = BUFFER_ALIGN;
tests/amdgpu/cs_tests.c +7 -1
index a01ee48..82c55aa 100644
@@ -76,8 +76,14 @@ int suite_cs_tests_init(void)
 
 	r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
 				     &minor_version, &device_handle);
-	if (r)
+	if (r) {
+		if ((r == -EACCES) && (errno == EACCES))
+			printf("\n\nError:%s. "
+				"Hint:Try to run this test program as root.",
+				strerror(errno));
+
 		return CUE_SINIT_FAILED;
+	}
 
 	family_id = device_handle->info.family_id;
 	/* VI asic POLARIS10/11 have specific external_rev_id */
tests/amdgpu/vce_tests.c +7 -1
index 4915170..de63aa1 100644
@@ -94,8 +94,14 @@ int suite_vce_tests_init(void)
 
 	r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
 				     &minor_version, &device_handle);
-	if (r)
+	if (r) {
+		if ((r == -EACCES) && (errno == EACCES))
+			printf("\n\nError:%s. "
+				"Hint:Try to run this test program as root.",
+				strerror(errno));
+
 		return CUE_SINIT_FAILED;
+	}
 
 	family_id = device_handle->info.family_id;
 	vce_harvest_config = device_handle->info.vce_harvest_config;
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1484255655-14848-1-git-send-email-AlexBin.Xie-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 12.01.2017 um 22:14 schrieb Alex Xie:

Quoted 15 lines

Before this change, the error message is:
"WARNING - Suite initialization failed..."
People might think this is a driver problem.

Tested with non-privileged user. Now the error message is like:
...
Error:Permission denied. Hint:Try to run this test program as root. WARNING - Suite initialization failed for 'Basic Tests'.
...

Tested as root with no regression.

amdgpu_test uses CUnit. CUnit outputs warning message to stdout. To be consistent, this commit outputs error message to stdout.

Quoted 7 lines

v2: Use strerror instead of %m. %m is a GNU C Library extension.
v3: Limit code and commit message within 80 characters per line.
Update commit message.
Remove a space before starting parenthesis in function call.

Change-Id Ib891c40ec812053f49ce5a99909455ac3137e32c

Works for me, patch is Reviewed-by: Christian König <[email protected]>.

IIRC I still don't have commit access to libdrm either, so Michel or Alex can anybody push this?

Regards,
Christian.

Quoted 76 lines
---
  tests/amdgpu/basic_tests.c | 7 ++++++-
  tests/amdgpu/bo_tests.c    | 8 +++++++-
  tests/amdgpu/cs_tests.c    | 8 +++++++-
  tests/amdgpu/vce_tests.c   | 8 +++++++-
  4 files changed, 27 insertions(+), 4 deletions(-)
tests/amdgpu/basic_tests.c +6 -1
index 11f6a63..bfda21b 100644
@@ -206,8 +206,13 @@ int suite_basic_tests_init(void)
 
  	if (r == 0)
  		return CUE_SUCCESS;
-	else
+	else {
+		if ((r == -EACCES) && (errno == EACCES))
+			printf("\n\nError:%s. "
+				"Hint:Try to run this test program as root.",
+				strerror(errno));
  		return CUE_SINIT_FAILED;
+	}
  }
 
  int suite_basic_tests_clean(void)
tests/amdgpu/bo_tests.c +7 -1
index 993895d..25df767 100644
@@ -65,8 +65,14 @@ int suite_bo_tests_init(void)
 
  	r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
  				  &minor_version, &device_handle);
-	if (r)
+	if (r) {
+		if ((r == -EACCES) && (errno == EACCES))
+			printf("\n\nError:%s. "
+				"Hint:Try to run this test program as root.",
+				strerror(errno));
+
  		return CUE_SINIT_FAILED;
+	}
 
  	req.alloc_size = BUFFER_SIZE;
  	req.phys_alignment = BUFFER_ALIGN;
tests/amdgpu/cs_tests.c +7 -1
index a01ee48..82c55aa 100644
@@ -76,8 +76,14 @@ int suite_cs_tests_init(void)
 
  	r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
  				     &minor_version, &device_handle);
-	if (r)
+	if (r) {
+		if ((r == -EACCES) && (errno == EACCES))
+			printf("\n\nError:%s. "
+				"Hint:Try to run this test program as root.",
+				strerror(errno));
+
  		return CUE_SINIT_FAILED;
+	}
 
  	family_id = device_handle->info.family_id;
  	/* VI asic POLARIS10/11 have specific external_rev_id */
tests/amdgpu/vce_tests.c +1 -1
index 4915170..de63aa1 100644
@@ -94,8 +94,14 @@ int suite_vce_tests_init(void)
 
  	r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
  				     &minor_version, &device_handle);
-	if (r)
+	if (r) {

tests/amdgpu/vce_tests.c int suite_vce_tests_init(void) · line 107

Quoted 10 lines
tests/amdgpu/vce_tests.c +6 -0
+		if ((r == -EACCES) && (errno == EACCES))
+			printf("\n\nError:%s. "
+				"Hint:Try to run this test program as root.",
+				strerror(errno));
+
  		return CUE_SINIT_FAILED;
+	}
 
  	family_id = device_handle->info.family_id;
  	vce_harvest_config = device_handle->info.vce_harvest_config;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 5e8dba7f-d96f-77b1-ef9e-3e358d3edc11-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

#4 lore raw
Quoted 26 lines · Christian König

Am 12.01.2017 um 22:14 schrieb Alex Xie:

Quoted 16 lines

Before this change, the error message is:
"WARNING - Suite initialization failed..."
People might think this is a driver problem.

Tested with non-privileged user. Now the error message is like:
...
Error:Permission denied. Hint:Try to run this test program as root. WARNING - Suite initialization failed for 'Basic Tests'.
...

Tested as root with no regression.

amdgpu_test uses CUnit. CUnit outputs warning message to stdout. To be consistent, this commit outputs error message to stdout.

Quoted 7 lines

v2: Use strerror instead of %m. %m is a GNU C Library extension.
v3: Limit code and commit message within 80 characters per line.
Update commit message.
Remove a space before starting parenthesis in function call.

Change-Id Ib891c40ec812053f49ce5a99909455ac3137e32c
Quoted 5 lines

Works for me, patch is Reviewed-by: Christian König <[email protected]>.

IIRC I still don't have commit access to libdrm either, so Michel or Alex can anybody push this?

Done. Thanks!

Alex

Quoted 86 lines

Regards,
Christian.

Quoted 81 lines
---
  tests/amdgpu/basic_tests.c | 7 ++++++-
  tests/amdgpu/bo_tests.c    | 8 +++++++-
  tests/amdgpu/cs_tests.c    | 8 +++++++-
  tests/amdgpu/vce_tests.c   | 8 +++++++-
  4 files changed, 27 insertions(+), 4 deletions(-)
tests/amdgpu/basic_tests.c +6 -1
index 11f6a63..bfda21b 100644
@@ -206,8 +206,13 @@ int suite_basic_tests_init(void)
        if (r == 0)
                return CUE_SUCCESS;
-       else
+       else {
+               if ((r == -EACCES) && (errno == EACCES))
+                       printf("\n\nError:%s. "
+                               "Hint:Try to run this test program as
 root.",
+                               strerror(errno));
                return CUE_SINIT_FAILED;
+       }
  }
    int suite_basic_tests_clean(void)
tests/amdgpu/bo_tests.c +7 -1
index 993895d..25df767 100644
@@ -65,8 +65,14 @@ int suite_bo_tests_init(void)
        r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
                                  &minor_version, &device_handle);
-       if (r)
+       if (r) {
+               if ((r == -EACCES) && (errno == EACCES))
+                       printf("\n\nError:%s. "
+                               "Hint:Try to run this test program as
 root.",
+                               strerror(errno));
+
                return CUE_SINIT_FAILED;
+       }
        req.alloc_size = BUFFER_SIZE;
        req.phys_alignment = BUFFER_ALIGN;
tests/amdgpu/cs_tests.c +7 -1
index a01ee48..82c55aa 100644
@@ -76,8 +76,14 @@ int suite_cs_tests_init(void)
        r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
                                     &minor_version, &device_handle);
-       if (r)
+       if (r) {
+               if ((r == -EACCES) && (errno == EACCES))
+                       printf("\n\nError:%s. "
+                               "Hint:Try to run this test program as
 root.",
+                               strerror(errno));
+
                return CUE_SINIT_FAILED;
+       }
        family_id = device_handle->info.family_id;
        /* VI asic POLARIS10/11 have specific external_rev_id */
tests/amdgpu/vce_tests.c +7 -1
index 4915170..de63aa1 100644
@@ -94,8 +94,14 @@ int suite_vce_tests_init(void)
        r = amdgpu_device_initialize(drm_amdgpu[0], &major_version,
                                     &minor_version, &device_handle);
-       if (r)
+       if (r) {
+               if ((r == -EACCES) && (errno == EACCES))
+                       printf("\n\nError:%s. "
+                               "Hint:Try to run this test program as
 root.",
+                               strerror(errno));
+
                return CUE_SINIT_FAILED;
+       }
        family_id = device_handle->info.family_id;
Quoted 8 lines

tests/amdgpu/vce_tests.c int suite_vce_tests_init(void) · line 107

Quoted 1 line
tests/amdgpu/vce_tests.c +0 -0
        vce_harvest_config = device_handle->info.vce_harvest_config;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx