Skip to contentSkip to conversation

syslog-ng: drop attempts to disable LFS

PATCH In review Andre McCurdy 2 participants 2 messages Jan 13, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syslog-ng: drop attempts to disable LFS

Forcefully disabling Large File Support in packages which enable it by default is probably not the right thing to do anymore. Since the syslog-ng configure.in file has been renamed to configure.ac, the existing sed command would fail anyway.

---
 meta-oe/recipes-support/syslog-ng/syslog-ng.inc | 4 ----
 1 file changed, 4 deletions(-)
meta-oe/recipes-support/syslog-ng/syslog-ng.inc +0 -4
index 0acdd73..4a66272 100644
@@ -56,10 +56,6 @@ PACKAGECONFIG[json] = "--enable-json,--disable-json,json-c,"
 PACKAGECONFIG[tcp-wrapper] = "--enable-tcp-wrapper,--disable-tcp-wrapper,tcp-wrappers,"
 PACKAGECONFIG[geoip] = "--enable-geoip,--disable-geoip,geoip,"
 
-do_configure_prepend() {
-    eval "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', '', 'sed -i -e "s/-D_LARGEFILE_SOURCE//" -e "s/-D_FILE_OFFSET_BITS=64//" ${S}/configure.in', d)}"
-}
-
 do_install_prepend() {
     sed -i -e 's,@SBINDIR@,${sbindir},g' ${S}/contrib/systemd/*.service
     sed -i -e 's,@LOCALSTATEDIR@,${localstatedir},g' ${S}/contrib/systemd/*.service
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · Andre McCurdy

Forcefully disabling Large File Support in packages which enable it by default is probably not the right thing to do anymore. Since the syslog-ng configure.in file has been renamed to configure.ac, the existing sed command would fail anyway.

Yes, moreover I think largefile support is more or less core feature now a days.

Quoted 22 lines
---
 meta-oe/recipes-support/syslog-ng/syslog-ng.inc | 4 ----
 1 file changed, 4 deletions(-)
meta-oe/recipes-support/syslog-ng/syslog-ng.inc +0 -4
index 0acdd73..4a66272 100644
@@ -56,10 +56,6 @@ PACKAGECONFIG[json] = "--enable-json,--disable-json,json-c,"
 PACKAGECONFIG[tcp-wrapper] = "--enable-tcp-wrapper,--disable-tcp-wrapper,tcp-wrappers,"
 PACKAGECONFIG[geoip] = "--enable-geoip,--disable-geoip,geoip,"
 
-do_configure_prepend() {
-    eval "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', '', 'sed -i -e "s/-D_LARGEFILE_SOURCE//" -e "s/-D_FILE_OFFSET_BITS=64//" ${S}/configure.in', d)}"
-}
-
 do_install_prepend() {
     sed -i -e 's,@SBINDIR@,${sbindir},g' ${S}/contrib/systemd/*.service
     sed -i -e 's,@LOCALSTATEDIR@,${localstatedir},g' ${S}/contrib/systemd/*.service