Skip to contentSkip to conversation

Patch "drm/tegra: dpaux: Fix error handling" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jan 15, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/tegra: dpaux: Fix error handling

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-tegra-dpaux-fix-error-handling.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9376cad2073d2c122864754ea5f80025c8507b0b Mon Sep 17 00:00:00 2001

From: Christophe Jaillet <[email protected]>
Date: Fri, 28 Oct 2016 11:09:45 +0200
Subject: drm/tegra: dpaux: Fix error handling

From: Christophe Jaillet <[email protected]>

commit 9376cad2073d2c122864754ea5f80025c8507b0b upstream.

The devm_pinctrl_register() function returns an error pointer or a valid handle. So checking for NULL here is pointless and can never trigger.

Check the returned value with IS_ERR instead and propagate this value as done in the other functions which call devm_pinctrl_register().

Fixes 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support")
---
 drivers/gpu/drm/tegra/dpaux.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/dpaux.c +2 -2
@@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct plat
 	dpaux->desc.owner = THIS_MODULE;
 
 	dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux);
-	if (!dpaux->pinctrl) {
+	if (IS_ERR(dpaux->pinctrl)) {
 		dev_err(&pdev->dev, "failed to register pincontrol\n");
-		return -ENODEV;
+		return PTR_ERR(dpaux->pinctrl);
 	}
 #endif
 	/* enable and clear all interrupts */

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/drm-tegra-dpaux-fix-error-handling.patch