Skip to contentSkip to conversation

drm/amdgpu/vi: fix mailbox irq mistake

PATCH In review Xiangliang Yu 2 participants 2 messages Jan 18, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 drm/amdgpu/vi: fix mailbox irq mistake

For virt, freed mailbox irq should be handled in hw fini, not hw init. Correct it.

---
 drivers/gpu/drm/amd/amdgpu/vi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/vi.c +3 -3
index 0c8f04e..89b0dfe 100644
@@ -1136,9 +1136,6 @@ static int vi_common_hw_init(void *handle)
 	/* enable the doorbell aperture */
 	vi_enable_doorbell_aperture(adev, true);
 
-	if (amdgpu_sriov_vf(adev))
-		xgpu_vi_mailbox_put_irq(adev);
-
 	return 0;
 }
 
@@ -1149,6 +1146,9 @@ static int vi_common_hw_fini(void *handle)
 	/* enable the doorbell aperture */
 	vi_enable_doorbell_aperture(adev, false);
 
+	if (amdgpu_sriov_vf(adev))
+		xgpu_vi_mailbox_put_irq(adev);
+
 	return 0;
 }
 
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1484715626-5749-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Monk Liu
#2 lore raw

________________________________
发件人: amd-gfx <[email protected]> 代表 Xiangliang Yu <[email protected]> 发送时间: 2017年1月18日 13:00:26
收件人: [email protected]
抄送: Yu, Xiangliang
主题: [PATCH 2/2] drm/amdgpu/vi: fix mailbox irq mistake

For virt, freed mailbox irq should be handled in hw fini, not hw init. Correct it.

---
 drivers/gpu/drm/amd/amdgpu/vi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/vi.c +3 -3
index 0c8f04e..89b0dfe 100644
@@ -1136,9 +1136,6 @@ static int vi_common_hw_init(void *handle)
         /* enable the doorbell aperture */
         vi_enable_doorbell_aperture(adev, true);
 
-       if (amdgpu_sriov_vf(adev))
-               xgpu_vi_mailbox_put_irq(adev);
-
         return 0;
 }
 
@@ -1149,6 +1146,9 @@ static int vi_common_hw_fini(void *handle)
         /* enable the doorbell aperture */
         vi_enable_doorbell_aperture(adev, false);
 
+       if (amdgpu_sriov_vf(adev))
+               xgpu_vi_mailbox_put_irq(adev);
+
         return 0;
 }
 

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx