arm: dts: imx53-cx9020: fix packetloss on fec_mxc
Subsystems (2)
PATCH 1/1 arm: dts: imx53-cx9020: fix packetloss on fec_mxc
From: Patrick Bruenn <[email protected]>
The pinmuxing for i.MX53 FEC ethernet copied from <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9) was bad. It is different from the manual pinmuxing in <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in cx9020 implementation previously before mainlining into u-boot. It seems the bug in imx53-qsb kernel device tree is hidden for so long, because it was never used, by the kernel driver.
---
arch/arm/dts/imx53-cx9020.dts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
arch/arm/dts/imx53-cx9020.dts +10 -10
@@ -114,16 +114,16 @@ MX53_PAD_SD2_CMD__ESDHC2_CMD 0x1d5 MX53_PAD_SD2_CLK__ESDHC2_CLK 0x1d5 - MX53_PAD_FEC_MDC__FEC_MDC 0x80000000 - MX53_PAD_FEC_MDIO__FEC_MDIO 0x80000000 - MX53_PAD_FEC_REF_CLK__FEC_TX_CLK 0x80000000 - MX53_PAD_FEC_RX_ER__FEC_RX_ER 0x80000000 - MX53_PAD_FEC_CRS_DV__FEC_RX_DV 0x80000000 - MX53_PAD_FEC_RXD1__FEC_RDATA_1 0x80000000 - MX53_PAD_FEC_RXD0__FEC_RDATA_0 0x80000000 - MX53_PAD_FEC_TX_EN__FEC_TX_EN 0x80000000 - MX53_PAD_FEC_TXD1__FEC_TDATA_1 0x80000000 - MX53_PAD_FEC_TXD0__FEC_TDATA_0 0x80000000 + MX53_PAD_FEC_MDC__FEC_MDC 0x4 + MX53_PAD_FEC_MDIO__FEC_MDIO 0x1fc + MX53_PAD_FEC_REF_CLK__FEC_TX_CLK 0x180 + MX53_PAD_FEC_RX_ER__FEC_RX_ER 0x180 + MX53_PAD_FEC_CRS_DV__FEC_RX_DV 0x180 + MX53_PAD_FEC_RXD1__FEC_RDATA_1 0x180 + MX53_PAD_FEC_RXD0__FEC_RDATA_0 0x180 + MX53_PAD_FEC_TX_EN__FEC_TX_EN 0x4 + MX53_PAD_FEC_TXD1__FEC_TDATA_1 0x4 + MX53_PAD_FEC_TXD0__FEC_TDATA_0 0x4 MX53_PAD_CSI0_DAT8__I2C1_SDA 0x400001ec MX53_PAD_CSI0_DAT9__I2C1_SCL 0x400001ec
Signature · 1 line
2.7.4
PATCH 1/1 arm: dts: imx53-cx9020: fix packetloss on fec_mxc
Quoted 11 lines · linux-kernel-dev at beckhoff.com
From: Patrick Bruenn <[email protected]>
The pinmuxing for i.MX53 FEC ethernet copied from <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9) was bad. It is different from the manual pinmuxing in <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in cx9020 implementation previously before mainlining into u-boot. It seems the bug in imx53-qsb kernel device tree is hidden for so long, because it was never used, by the kernel driver.
Signed-off-by Patrick Bruenn <[email protected]>
So in other words, the dts file is correct in current mainline kernel? Or still pending? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170123/350de686/attachment.sig>
PATCH 1/1 arm: dts: imx53-cx9020: fix packetloss on fec_mxc
Quoted 16 lines
From: Tom Rini [mailto:trini at konsulko.com]
Sent: Montag, 23. Januar 2017 16:31Quoted 10 lines · linux-kernel-dev at beckhoff.com
From: Patrick Bruenn <[email protected]>
The pinmuxing for i.MX53 FEC ethernet copied from <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9) was bad. It is different from the manual pinmuxing in <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in cx9020 implementation previously before mainlining into u-boot. It seems the bug in imx53-qsb kernel device tree is hidden for so long, because it was never used, by the kernel driver.
Quoted 4 lines
Quoted 1 line
Signed-off-by Patrick Bruenn <[email protected]>So in other words, the dts file is correct in current mainline kernel? Or still pending? Thanks!
Sorry, no it is still pending. I just reported it to the kernel maintainers:
https://mail-archive.com/linux-kernel at vger.kernel.org/msg1316717.html
Patrick
PATCH 1/1 arm: dts: imx53-cx9020: fix packetloss on fec_mxc
Quoted 16 lines · linux-kernel-dev
Quoted 16 lines
From: Tom Rini [mailto:trini at konsulko.com]
Sent: Montag, 23. Januar 2017 16:31Quoted 10 lines · linux-kernel-dev at beckhoff.com
From: Patrick Bruenn <[email protected]>
The pinmuxing for i.MX53 FEC ethernet copied from <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9) was bad. It is different from the manual pinmuxing in <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in cx9020 implementation previously before mainlining into u-boot. It seems the bug in imx53-qsb kernel device tree is hidden for so long, because it was never used, by the kernel driver.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Patrick Bruenn <[email protected]>So in other words, the dts file is correct in current mainline kernel? Or still pending? Thanks!
Sorry, no it is still pending. I just reported it to the kernel maintainers:
https://mail-archive.com/linux-kernel at vger.kernel.org/msg1316717.html
Ah, OK. I think we want get this in the release, but it can wait for -rc3 or so, unless it gets ack'ed by the kernel folks sooner. Please keep us apprised, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170123/4406c1bf/attachment.sig>
PATCH 1/1 arm: dts: imx53-cx9020: fix packetloss on fec_mxc
Quoted 19 lines · Tom Rini
Quoted 18 lines · linux-kernel-dev
Quoted 18 lines
From: Tom Rini [mailto:trini at konsulko.com]
Sent: Montag, 23. Januar 2017 16:31Quoted 11 lines · linux-kernel-dev at beckhoff.com
From: Patrick Bruenn <[email protected]>
The pinmuxing for i.MX53 FEC ethernet copied from <kernel>/arch/arm/boot/dts/imx53-qsb-common.dtsi (at least until v4.9) was bad. It is different from the manual pinmuxing in <u-boot>/board/freescale/mx53loco/mx53loco.c which was used in cx9020 implementation previously before mainlining into u-boot. It seems the bug in imx53-qsb kernel device tree is hidden for so long, because it was never used, by the kernel driver.
Signed-off-by Patrick Bruenn <[email protected]>
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
So in other words, the dts file is correct in current mainline kernel? Or still pending? Thanks!
Sorry, no it is still pending. I just reported it to the kernel maintainers:
https://mail-archive.com/linux-kernel at vger.kernel.org/msg1316717.htmlAh, OK. I think we want get this in the release, but it can wait for -rc3 or so, unless it gets ack'ed by the kernel folks sooner. Please keep us apprised, thanks!
I saw patch was integrated in kernel - I merge this as well in u-boot-imx.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================