Skip to contentSkip to conversation

Patch "mtd: spi-nor: Off by one in cqspi_setup_flash()" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jan 23, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mtd: spi-nor: Off by one in cqspi_setup_flash()

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mtd-spi-nor-off-by-one-in-cqspi_setup_flash.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 193e87143c290ec16838f5368adc0e0bc94eb931 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Thu, 13 Oct 2016 11:06:47 +0300
Subject: mtd: spi-nor: Off by one in cqspi_setup_flash()

From: Dan Carpenter <[email protected]>

commit 193e87143c290ec16838f5368adc0e0bc94eb931 upstream.

There are CQSPI_MAX_CHIPSELECT elements in the ->f_pdata array so the > should be >=.

Fixes 140623410536 ('mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller')
---
 drivers/mtd/spi-nor/cadence-quadspi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi-nor/cadence-quadspi.c +1 -1
@@ -1082,7 +1082,7 @@ static int cqspi_setup_flash(struct cqsp
 			goto err;
 		}
 
-		if (cs > CQSPI_MAX_CHIPSELECT) {
+		if (cs >= CQSPI_MAX_CHIPSELECT) {
 			dev_err(dev, "Chip select %d out of range.\n", cs);
 			goto err;
 		}

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/st-hva-fix-some-error-handling-in-hva_hw_probe.patch queue-4.9/mtd-spi-nor-fix-some-error-codes-in-cqspi_setup_flash.patch queue-4.9/blackfin-check-devm_pinctrl_get-for-errors.patch queue-4.9/mtd-spi-nor-off-by-one-in-cqspi_setup_flash.patch queue-4.9/ieee802154-atusb-do-not-use-the-stack-for-buffers-to-make-them-dma-able.patch