Skip to contentSkip to conversation

drm/i915/gvt/kvmgt: remove useless code

PATCH New Jike Song 2 participants 2 messages Jan 26, 2017

Subsystems (3)
lore
Share & tools
lore

Jike Song

author
#0 lore raw

PATCH 1/1 drm/i915/gvt/kvmgt: remove useless code

As noticed by Dan, there is useless (and incorrect) code in kvmgt trying to kfree(NULL), though almost harmless. It was a copy-paste mistake and should be removed.

---
 drivers/gpu/drm/i915/gvt/kvmgt.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/i915/gvt/kvmgt.c +0 -7
index f0a993a..68737dc 100644
@@ -965,13 +965,7 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
 			sparse->areas[0].offset =
 					PAGE_ALIGN(vgpu_aperture_offset(vgpu));
 			sparse->areas[0].size = vgpu_aperture_sz(vgpu);
-			if (!caps.buf) {
-				kfree(caps.buf);
-				caps.buf = NULL;
-				caps.size = 0;
-			}
 			break;
-
 		case VFIO_PCI_BAR3_REGION_INDEX ... VFIO_PCI_BAR5_REGION_INDEX:
 			info.offset = VFIO_PCI_INDEX_TO_OFFSET(info.index);
 			info.size = 0;
@@ -979,7 +973,6 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
 			info.flags = 0;
 			gvt_dbg_core("get region info bar:%d\n", info.index);
 			break;
-
 		case VFIO_PCI_ROM_REGION_INDEX:
 		case VFIO_PCI_VGA_REGION_INDEX:
 			gvt_dbg_core("get region info index:%d\n", info.index);
Signature · 6 lines
2.4.4.488.gdf97e5d

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: warning for drm/i915/gvt/kvmgt: remove useless code

== Series Details ==

== Series Details ==

Series: drm/i915/gvt/kvmgt: remove useless code
URL : https://patchwork.freedesktop.org/series/18581/
State : warning

== Summary ==

Series 18581v1 drm/i915/gvt/kvmgt: remove useless code
https://patchwork.freedesktop.org/api/1.0/series/18581/revisions/1/mbox/

Test kms_force_connector_basic:

        Subgroup force-edid:
                pass       -> DMESG-WARN (fi-snb-2520m)
fi-bdw-5557u     total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14 
fi-bsw-n3050     total:247  pass:208  dwarn:0   dfail:0   fail:0   skip:39 
fi-bxt-j4205     total:247  pass:225  dwarn:0   dfail:0   fail:0   skip:22 
fi-bxt-t5700     total:79   pass:66   dwarn:0   dfail:0   fail:0   skip:12 
fi-byt-j1900     total:247  pass:220  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:247  pass:216  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19 
fi-hsw-4770r     total:247  pass:228  dwarn:0   dfail:0   fail:0   skip:19 
fi-ivb-3520m     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-kbl-7500u     total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6260u     total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13 
fi-skl-6700hq    total:247  pass:227  dwarn:0   dfail:0   fail:0   skip:20 
fi-skl-6700k     total:247  pass:222  dwarn:4   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:247  pass:234  dwarn:0   dfail:0   fail:0   skip:13 
fi-snb-2520m     total:247  pass:215  dwarn:1   dfail:0   fail:0   skip:31 
fi-snb-2600      total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32 

640548d96a90b3cb4769ff151057f2aab808fdd2 drm-tip: 2017y-01m-25d-15h-41m-28s UTC integration manifest 6d2060c drm/i915/gvt/kvmgt: remove useless code

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3607/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx