patch "usb: dwc3: gadget: skip Set/Clear Halt when invalid" added to usb-next
Subsystems (3)
This is a note to let you know that I've just added the patch titled
usb: dwc3: gadget: skip Set/Clear Halt when invalid
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will also be merged in the next major kernel release during the merge window.
If you have any questions about this process, please let me know.
Quoted 1 line
From
ffb80fc672c3a7b6afd0cefcb1524fb99917b2f3Mon Sep 17 00:00:00 2001
From: Felipe Balbi <[email protected]>
Date: Thu, 19 Jan 2017 13:38:42 +0200
Subject: usb: dwc3: gadget: skip Set/Clear Halt when invalid
At least macOS seems to be sending ClearFeature(ENDPOINT_HALT) to endpoints which aren't Halted. This makes DWC3's CLEARSTALL command time out which causes several issues for the driver.
Instead, let's just return 0 and bail out early.
--- drivers/usb/dwc3/gadget.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/usb/dwc3/gadget.c +5 -0
@@ -1379,6 +1379,9 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol)unsigned transfer_in_flight;unsigned started; +if (dep->flags &DWC3_EP_STALL ) +return 0 ; +if (dep->number >1 ) trb =dwc3_ep_prev_trb (dep, dep->trb_enqueue);else
@@ -1400,6 +1403,8 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol)else dep->flags |=DWC3_EP_STALL ; }else { +if (!(dep->flags &DWC3_EP_STALL )) +return 0 ; ret =dwc3_send_clear_stall_ep_cmd (dep);if (ret)
Signature · 1 line
2.11.0